Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the version of GraalVM CE used by ShardingSphere Proxy Native to 23.0.1 #27487

Merged
merged 2 commits into from
Aug 12, 2023

Conversation

linghengqian
Copy link
Member

@linghengqian linghengqian commented Jul 26, 2023

For #21347.

Changes proposed in this pull request:

  • Update the GraalVM version used by ShardingSphere Proxy Native to 23.0.1.
  • Update the Maven plugin for GraalVM Native Build Tools to 0.9.24.
  • https://github.com/graalvm/graalvm-jdk-downloader was archived on July 26, 2023, and Dockerfile has been modified.
  • Espresso's java.MultiThreaded option default value is True and is no longer specified manually.
  • Refactor EspressoInlineExpressionParser to compress the Classpath required for the context created by Espresso. This is related to the new limitations on GraalVM CE 23.0.1.
  • Add the shardingsphere-infra-expr-purelist module to replace the shardingsphere-infra-expr-espresso module. org.graalvm.truffle:truffle-api:23.0.1 successfully broke the Native Image build, and I'll explore this in a separate GraalVM issue.

Before committing this PR, I'm sure that I have checked the following options:

  • My code follows the code of conduct of this project.
  • I have self-reviewed the commit code.
  • I have (or in comment I request) added corresponding labels for the pull request.
  • I have passed maven check locally : ./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.
  • I have made corresponding changes to the documentation.
  • I have added corresponding unit tests for my changes.

@linghengqian linghengqian force-pushed the update-graalvm-ci branch 6 times, most recently from 89a2220 to b0e8c4f Compare July 26, 2023 21:08
@linghengqian linghengqian changed the title Update the version of GraalVM used by ShardingSphere Proxy Native to 23.0.0 Update the version of GraalVM CE used by ShardingSphere Proxy Native to 23.0.0 Jul 26, 2023
@linghengqian linghengqian force-pushed the update-graalvm-ci branch 4 times, most recently from 727e75a to 719fd56 Compare July 27, 2023 09:20
@linghengqian linghengqian force-pushed the update-graalvm-ci branch 3 times, most recently from f7f6162 to 2999c62 Compare July 27, 2023 15:56
@linghengqian linghengqian marked this pull request as ready for review July 27, 2023 16:40
Copy link
Member Author

@linghengqian linghengqian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • @terrymanu Hi, can you help Review? I'm not quite sure if the name of this new module shardingsphere-infra-expr-purelist is appropriate.

  • The Native Image build in GraalVM 23.0.1 should be fixed after this PR is merged.

./mvnw -PgenerateStandardMetadata -DskipNativeTests -B -T1C clean test
./mvnw -am -pl distribution/proxy-native -B -T1C -Prelease.native -DskipTests clean package

@linghengqian linghengqian force-pushed the update-graalvm-ci branch 2 times, most recently from 0892842 to ae9284e Compare July 31, 2023 15:59
@linghengqian linghengqian changed the title Update the version of GraalVM CE used by ShardingSphere Proxy Native to 23.0.0 Update the version of GraalVM CE used by ShardingSphere Proxy Native to 23.0.1 Aug 4, 2023
@linghengqian linghengqian force-pushed the update-graalvm-ci branch 2 times, most recently from 92ab477 to 596ee6a Compare August 9, 2023 10:14
@terrymanu terrymanu added this to the 5.4.1 milestone Aug 12, 2023
@terrymanu terrymanu merged commit bb2dd94 into apache:master Aug 12, 2023
@linghengqian linghengqian deleted the update-graalvm-ci branch August 12, 2023 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants