Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use CaseInsensitiveMap to replace toLowerCase method call #32595

Merged
merged 1 commit into from
Aug 20, 2024
Merged

Use CaseInsensitiveMap to replace toLowerCase method call #32595

merged 1 commit into from
Aug 20, 2024

Conversation

strongduanmu
Copy link
Member

@strongduanmu strongduanmu commented Aug 19, 2024 •
edited
Loading

Fixes #ISSUSE_ID.

Changes proposed in this pull request:

  • Use CaseInsensitiveMap to replace toLowerCase method call

Before committing this PR, I'm sure that I have checked the following options:

  • My code follows the code of conduct of this project.
  • I have self-reviewed the commit code.
  • I have (or in comment I request) added corresponding labels for the pull request.
  • I have passed maven check locally : ./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.
  • I have made corresponding changes to the documentation.
  • I have added corresponding unit tests for my changes.

@strongduanmu strongduanmu added this to the 5.5.1 milestone Aug 19, 2024
@strongduanmu
Copy link
Member Author

image

@strongduanmu strongduanmu marked this pull request as draft August 19, 2024 11:30
@strongduanmu strongduanmu marked this pull request as ready for review August 20, 2024 00:06
@FlyingZC FlyingZC merged commit 9c4fa90 into apache:master Aug 20, 2024
141 checks passed
@strongduanmu strongduanmu deleted the dev-0819 branch August 20, 2024 00:13
RaigorJiang added a commit that referenced this pull request Oct 22, 2024
@RaigorJiang
Pick #32595, #32763, fix the generated key column name case insensiti…
aa2cf56 
…vity error (#8)

* Pick #32595, #32763, fix the generated key column name case insensitivity error

* Improve DML E2E to support destroy-sql

* Optimize code style
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FlyingZC FlyingZC FlyingZC approved these changes

Assignees
No one assigned
Labels
in: metadata type: refactor
Projects
None yet
Milestone
5.5.1
Development

Successfully merging this pull request may close these issues.
2 participants
@strongduanmu @FlyingZC