Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the parsing of methods in MySQL #32599

Merged
merged 2 commits into from
Aug 26, 2024
Merged

Improve the parsing of methods in MySQL #32599

merged 2 commits into from
Aug 26, 2024

Conversation

lushaorong
Copy link
Contributor

Fixes #31558.

Changes proposed in this pull request:

  • Improve the parsing of methods in MySQL

Before committing this PR, I'm sure that I have checked the following options:

  • My code follows the code of conduct of this project.
  • I have self-reviewed the commit code.
  • I have (or in comment I request) added corresponding labels for the pull request.
  • I have passed maven check locally : ./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.
  • I have made corresponding changes to the documentation.
  • I have added corresponding unit tests for my changes.

@strongduanmu strongduanmu added this to the 5.5.1 milestone Aug 26, 2024
strongduanmu
strongduanmu approved these changes Aug 26, 2024
View reviewed changes
Copy link
Member

@strongduanmu strongduanmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks so great, merged.

@strongduanmu strongduanmu merged commit e559690 into apache:master Aug 26, 2024
141 checks passed
@strongduanmu
Copy link
Member

Hi @lushaorong, could you please check if Doris supports these statements? If so, please submit another PR.

@lushaorong
Copy link
Contributor Author

Hi @lushaorong, could you please check if Doris supports these statements? If so, please submit another PR.

I can try it

@lushaorong lushaorong deleted the dev-31566 branch August 26, 2024 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@strongduanmu strongduanmu strongduanmu approved these changes

Assignees
No one assigned
Labels
db: MySQL in: SQL parse type: enhancement
Projects
None yet
Milestone
5.5.1
Development

Successfully merging this pull request may close these issues.

Improve the parsing of methods in MySQL
2 participants
@lushaorong @strongduanmu