Issue#322 add sofa plugin #384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #384 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 23 24 +1
Lines 61 62 +1
Branches 1 1
======================================
- Misses 61 62 +1
Continue to review full report at Codecov.
|
dengliming
reviewed
Nov 24, 2020
| * @return the plugin data handler | ||
| */ | ||
| @Bean | ||
| public PluginDataHandler sofaoPluginDataHandler() { |
There was a problem hiding this comment.
sofaoPluginDataHandler这里是不是多了个o
dengliming
approved these changes
Nov 24, 2020
There was a problem hiding this comment.
👍 另外我想问下，license header是不是每个文件都要加的，我看现在有些文件有，有些没有 @yu199195
昨天太晚了我没加 后续我都会补上的 |
|
@tydhot 在这个pr里面把文件头山的 lincense都加上把 |
|
@yu199195 license header如果是必须的就maven中增加检查头部吧？ |
Closed
Zhoutzzz
pushed a commit
to Zhoutzzz/shenyu
that referenced
this pull request
Nov 26, 2020
* [apache#322]prepare add sofa plugin * [apache#322]add sofa plugin * [apache#322]add licenses
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.