-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SHIRO-679] Shiro modules have split packages #236
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
I only took a quick pass through, but this is great.
As a bonus, it makes it easier to see what else is left in "core" that might need to be moved around (ini, jndi, ldap), but that is a topic for another thread :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for taking care of this!
Browsed through it twice or thrice, haven't picked up anything suspicious
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me as a first step to cleanup.
Thanks guys for the review, I merge it and we can move forward on 2.0.0! |
Modules
config/ogdl:
core:
crypto:
lang:
support/feature:
Global
Tested on Apache Karaf 4.2.8