Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SHIRO-893] - Fix NPE in ShiroFilter.init() #499

Merged
merged 1 commit into from
Oct 26, 2022

Conversation

julian-computes
Copy link
Contributor

@julian-computes julian-computes commented Oct 18, 2022

Fixes SHIRO-893.

In 1.10.0, an NPE can be thrown because DefaultWebEnvironment has no default value for ShiroFilterConfiguration. This commit adds a default value determined by WebEnvironment.getShiroFilterConfiguration().

@fpapon fpapon self-requested a review October 20, 2022 07:26
Copy link
Member

@fpapon fpapon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@julian-computes thanks for your contribution!

@bmarwell
Copy link
Contributor

@julian-computes can you please rename the commit message so we get a [SHIRO-893] in front?

@julian-computes
Copy link
Contributor Author

@bmarwell I've just done so. Apologies for the extra merge commit.

@fpapon
Copy link
Member

fpapon commented Oct 26, 2022

@julian-computes Can you squash the commits please? It's better to have only one for the history.

In 1.10.0, an NPE can be thrown because DefaultWebEnvironment has no default value for ShiroFilterConfiguration. This commit adds a default value determined by WebEnvironment.getShiroFilterConfiguration().
@julian-computes
Copy link
Contributor Author

Yes, true. Squashed now.

@bmarwell bmarwell merged commit efbd28c into apache:1.10.x Oct 26, 2022
@julian-computes julian-computes deleted the shiro_filter_config_npe_fix branch October 26, 2022 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants