Adding attachment fields to describe the environment in eBPF ALS #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wu-sheng
reviewed
Sep 14, 2024
|
|
||
| message ZTunnelAttachmentEnvironment { | ||
| // the real destination ip address of the connection | ||
| string real_destination_ip = 1; |
There was a problem hiding this comment.
Could we add an emun by to indicate how we resolve the real IP?
There was a problem hiding this comment.
Where do we need to use this enum?
There was a problem hiding this comment.
We don't, but we can tell which part of the logic made this. Helpful for debug only.
There was a problem hiding this comment.
I have added a new enum to describe how the rover detects and resolves the real dest IP. Is this work for you?
wu-sheng
approved these changes
Sep 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.