Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update: add weak-compatible to dependency check #171

Merged
merged 11 commits into from
Nov 1, 2023
Merged

update: add weak-compatible to dependency check #171

merged 11 commits into from
Nov 1, 2023

Conversation

Two-Hearts
Copy link
Contributor

This PR is based on this discussion: apache/skywalking#11391.
A new list called weak-compatible is added to the skywalking-eyes compatibility list.
A new flag called weak-compatible is added to the dependency check command.

@Two-Hearts
added new list for MPL 2.0
e1157dc 
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@Two-Hearts
test
7ec7d1b 
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@Two-Hearts
test
0be2be3 
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@Two-Hearts
test
a64b114 
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@Two-Hearts
test
eb0d9f5 
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@Two-Hearts
added compatible-with-conditions flag to deps check
1ad3010 
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@Two-Hearts
fixed compatible-with-conditions
1f9512c 
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@Two-Hearts
added weak-compatible list to dependency check
b04be22 
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@Two-Hearts
clean up
dec8478 
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@wu-sheng wu-sheng added this to the 0.6.0 milestone Oct 31, 2023
@wu-sheng
Copy link
Member

Thanks for raising this. Please fix the CI first.

@Two-Hearts
Copy link
Contributor Author

Working on the CI, looks like a lint problem.

kezhenxu94
kezhenxu94 reviewed Oct 31, 2023
View reviewed changes
Copy link
Member

@kezhenxu94 kezhenxu94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A tiny suggestion about the description of the new command option, others look good to me, LGTM after CI is passed

commands/deps_check.go Outdated Show resolved Hide resolved
@Two-Hearts
fixing lint
364b52e 
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@Two-Hearts
fixed CI
820e28e 
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
wu-sheng
wu-sheng approved these changes Nov 1, 2023
View reviewed changes
Copy link
Member

@wu-sheng wu-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to have this. Wait for @kezhenxu94 on codes.

kezhenxu94
kezhenxu94 approved these changes Nov 1, 2023
View reviewed changes
Copy link
Member

@kezhenxu94 kezhenxu94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! @Two-Hearts

@kezhenxu94 kezhenxu94 merged commit a790ab8 into apache:main Nov 1, 2023
1 check passed
mkolasinski-splunk referenced this pull request in splunk/addonfactory-workflow-addon-release Apr 16, 2024
@renovate @mkolasinski-splunk
chore(deps): update all dependencies (#151)
cceadb1 
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [apache/skywalking-eyes](https://togithub.com/apache/skywalking-eyes)
| action | minor | `v0.5.0` -> `v0.6.0` |
|
[aws-actions/configure-aws-credentials](https://togithub.com/aws-actions/configure-aws-credentials) |
| action | major | `v2` -> `v3` |
| [docker/metadata-action](https://togithub.com/docker/metadata-action) |
| action | minor | `v5.4.0` -> `v5.5.1` |
| [pre-commit/action](https://togithub.com/pre-commit/action) | action |
patch | `v3.0.0` -> `v3.0.1` |

---

### Release Notes

<details>
<summary>apache/skywalking-eyes (apache/skywalking-eyes)</summary>

###
[`v0.6.0`](https://togithub.com/apache/skywalking-eyes/releases/tag/v0.6.0)

[Compare
Source](https://togithub.com/apache/skywalking-eyes/compare/v0.5.0...v0.6.0)

#### What's Changed

- Add `|` as comment indicator by
[@&#8203;kezhenxu94](https://togithub.com/kezhenxu94) in
[https://github.com/apache/skywalking-eyes/pull/168](https://togithub.com/apache/skywalking-eyes/pull/168)
- Correct the way of joining slack channels by
[@&#8203;wu-sheng](https://togithub.com/wu-sheng) in
[https://github.com/apache/skywalking-eyes/pull/169](https://togithub.com/apache/skywalking-eyes/pull/169)
- update: add weak-compatible to dependency check by
[@&#8203;Two-Hearts](https://togithub.com/Two-Hearts) in
[https://github.com/apache/skywalking-eyes/pull/171](https://togithub.com/apache/skywalking-eyes/pull/171)
- feature: add support for Protocol Buffer by
[@&#8203;spacewander](https://togithub.com/spacewander) in
[https://github.com/apache/skywalking-eyes/pull/172](https://togithub.com/apache/skywalking-eyes/pull/172)
- feature: add support for OPA policy files by
[@&#8203;spacewander](https://togithub.com/spacewander) in
[https://github.com/apache/skywalking-eyes/pull/174](https://togithub.com/apache/skywalking-eyes/pull/174)
- add Eclipse Foundation specific Apache 2.0 license header by
[@&#8203;gdams](https://togithub.com/gdams) in
[https://github.com/apache/skywalking-eyes/pull/178](https://togithub.com/apache/skywalking-eyes/pull/178)
- add instructions to fix header issues in markdown comment by
[@&#8203;gdams](https://togithub.com/gdams) in
[https://github.com/apache/skywalking-eyes/pull/179](https://togithub.com/apache/skywalking-eyes/pull/179)
- bump action/setup-go to v5 by
[@&#8203;gdams](https://togithub.com/gdams) in
[https://github.com/apache/skywalking-eyes/pull/180](https://togithub.com/apache/skywalking-eyes/pull/180)
- Draft release notes for 0.6.0 by
[@&#8203;kezhenxu94](https://togithub.com/kezhenxu94) in
[https://github.com/apache/skywalking-eyes/pull/181](https://togithub.com/apache/skywalking-eyes/pull/181)

#### New Contributors

- [@&#8203;Two-Hearts](https://togithub.com/Two-Hearts) made their first
contribution in
[https://github.com/apache/skywalking-eyes/pull/171](https://togithub.com/apache/skywalking-eyes/pull/171)
- [@&#8203;gdams](https://togithub.com/gdams) made their first
contribution in
[https://github.com/apache/skywalking-eyes/pull/178](https://togithub.com/apache/skywalking-eyes/pull/178)

**Full Changelog**:
apache/skywalking-eyes@v0.5.0...v0.6.0

</details>

<details>
<summary>aws-actions/configure-aws-credentials
(aws-actions/configure-aws-credentials)</summary>

###
[`v4`](https://togithub.com/aws-actions/configure-aws-credentials/releases/tag/v4)

[Compare
Source](https://togithub.com/aws-actions/configure-aws-credentials/compare/v3...v4)

This tag tracks the latest v4.x.x release

###
[`v3`](https://togithub.com/aws-actions/configure-aws-credentials/releases/tag/v3)

[Compare
Source](https://togithub.com/aws-actions/configure-aws-credentials/compare/v2...v3)

This tag tracks the latest v3.x.x release

</details>

<details>
<summary>docker/metadata-action (docker/metadata-action)</summary>

###
[`v5.5.1`](https://togithub.com/docker/metadata-action/releases/tag/v5.5.1)

[Compare
Source](https://togithub.com/docker/metadata-action/compare/v5.5.0...v5.5.1)

- Don't set `cwd://` prefix for local bake files by
[@&#8203;crazy-max](https://togithub.com/crazy-max) in
[https://github.com/docker/metadata-action/pull/382](https://togithub.com/docker/metadata-action/pull/382)

**Full Changelog**:
docker/metadata-action@v5.5.0...v5.5.1

###
[`v5.5.0`](https://togithub.com/docker/metadata-action/releases/tag/v5.5.0)

[Compare
Source](https://togithub.com/docker/metadata-action/compare/v5.4.0...v5.5.0)

- Set `cwd://` prefix for bake files path by
[@&#8203;crazy-max](https://togithub.com/crazy-max) in
[https://github.com/docker/metadata-action/pull/370](https://togithub.com/docker/metadata-action/pull/370)
- Bump
[@&#8203;docker/actions-toolkit](https://togithub.com/docker/actions-toolkit)
from 0.16.0 to 0.16.1 in
[https://github.com/docker/metadata-action/pull/371](https://togithub.com/docker/metadata-action/pull/371)
- Bump moment from 2.29.4 to 2.30.1 in
[https://github.com/docker/metadata-action/pull/373](https://togithub.com/docker/metadata-action/pull/373)
- Bump moment-timezone from 0.5.43 to 0.5.44 in
[https://github.com/docker/metadata-action/pull/374](https://togithub.com/docker/metadata-action/pull/374)

**Full Changelog**:
docker/metadata-action@v5.4.0...v5.5.0

</details>

<details>
<summary>pre-commit/action (pre-commit/action)</summary>

###
[`v3.0.1`](https://togithub.com/pre-commit/action/releases/tag/v3.0.1):
pre-commit/action@v3.0.1

[Compare
Source](https://togithub.com/pre-commit/action/compare/v3.0.0...v3.0.1)

##### Misc

- [#&#8203;190](https://togithub.com/pre-commit/action/issues/190) PR by
[@&#8203;SukiCZ](https://togithub.com/SukiCZ).
- [#&#8203;189](https://togithub.com/pre-commit/action/issues/189) issue
by [@&#8203;bakerkj](https://togithub.com/bakerkj).

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "before 4am on Monday" (UTC),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get
[config help](https://togithub.com/renovatebot/renovate/discussions) if
that's undesired.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/splunk/addonfactory-workflow-addon-release).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS45OC40IiwidXBkYXRlZEluVmVyIjoiMzcuMjY5LjIiLCJ0YXJnZXRCcmFuY2giOiJkZXZlbG9wIn0=-->

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: mkolasinski-splunk <mkolasinski@splunk.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kezhenxu94 kezhenxu94 kezhenxu94 approved these changes

@wu-sheng wu-sheng wu-sheng approved these changes

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
0.6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Two-Hearts @wu-sheng @kezhenxu94