Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix method name missing in spring-plugins:scheduled-annotation-plugin with spring 6.1.x #691

Merged
merged 3 commits into from
May 14, 2024

Conversation

CzyerChen
Copy link
Contributor

Fix method name missing in spring-plugins:scheduled-annotation-plugin with spring 6.1.x

  • Add a unit test to verify that the fix works.
  • Explain briefly why the bug exists and how to fix it.

Since Spring 6.1.x, the intercepted method deprecated

  @Deprecated(
        since = "6.1"
    )
    @Nullable
    protected Runnable createRunnable(Object target, Method method) {
        return null;
    }

use the constructor method instead:

  public ScheduledMethodRunnable(Object target, Method method, @Nullable String qualifier, Supplier<ObservationRegistry> observationRegistrySupplier) {
        this.target = target;
        this.method = method;
        this.qualifier = qualifier;
        this.observationRegistrySupplier = observationRegistrySupplier;
    }

Before adjustment:

image

the method name missing wiith Spring 6.1.x

Now:

image

Meanwhile, optimize test cases of spring-scheduled.

CHANGES.md Outdated Show resolved Hide resolved
@wu-sheng wu-sheng added this to the 9.3.0 milestone May 13, 2024
@wu-sheng wu-sheng added enhancement New feature or request plugin labels May 13, 2024
@wu-sheng
Copy link
Member

I can see RocketMQ case fails again.

@CzyerChen
Copy link
Contributor Author

I can see RocketMQ case fails again.

OK,I will check RocketMQ case first.

@CzyerChen
Copy link
Contributor Author

I can see RocketMQ case fails again.

The problem is not reproduced locally, and the sending and receiving of async messages are enhanced.

Please do inform me when the recurrence of the problem.

@wu-sheng
Copy link
Member

Are we sending too frequently? The test GHA env is only 3u8g for all runtime. It could be super slow.

wu-sheng
wu-sheng previously approved these changes May 14, 2024
@CzyerChen
Copy link
Contributor Author

Are we sending too frequently? The test GHA env is only 3u8g for all runtime. It could be super slow.

May have an impact.

@wu-sheng
Copy link
Member

I can see RocketMQ fails again. From what I see, 50% chance fails

@wu-sheng wu-sheng merged commit 4dfc1e8 into apache:main May 14, 2024
191 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants