Support for tracing the callbacks of async methods in elastiicsearch-6.x/7.x-plugin #694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…earch-6.x-plugin/elasticsearch-7.x-plugin.
wu-sheng
reviewed
May 25, 2024
wu-sheng
reviewed
May 25, 2024
|
|
||
| // refresh | ||
| client.indices().refresh(new RefreshRequest(indexName), RequestOptions.DEFAULT); | ||
| Thread.sleep(1000); |
There was a problem hiding this comment.
Do we have another way to verify the request has been verified?
Such as, do it through query or callback?
There was a problem hiding this comment.
Sleep usually is not stable when doing this, when resource is limited in GHA scenario.
There was a problem hiding this comment.
OK, I will improve that.
|
Could you verify that, is virtual database working as expected? |
Looks it's working as well. |
wu-sheng
previously approved these changes
May 27, 2024
|
ES-7.x case may fail again due to the limited resources. |
|
Test cases fail. You may need some recheck. |
Let me think twice. |
wu-sheng
approved these changes
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for tracing the callbacks of async methods in elastiicsearch-6.x/7.x-plugin
CHANGESlog.callbacks(onResponse/onFailure) for
Trace details:
record
transmission.latencywhen callback:7.0.0 - 7.2.1 not included in the test because analyze method appears since 7.3.0