Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix child spans created on immediate cb from op #41

Merged
merged 1 commit into from
Mar 24, 2021

Conversation

tom-pytel
Copy link
Contributor

Two MongoDB fixes here:

  • Added flag to indicate whether mongodb is inside an internal call to be able to differentiate when a recursed operation belongs to mongo or the user so that user spans are properly created in case of an immediate callback from mongo but not in case of recursed mongo operations.
  • mapReduce will show string functions quoted to differentiate from real passed functions.

@tom-pytel
Copy link
Contributor Author

tom-pytel commented Mar 23, 2021

Something strange is going on with the tests, first the Node 10 TestPlugins test failed but the others succeeded, now Node 10 and 12 successful but Node 14 Build failed for a strange reason:

npm ERR! cb() never called!

npm ERR! This is an error with npm itself. Please report this error at:

@tom-pytel
Copy link
Contributor Author

Looks like it fixed itself.

@kezhenxu94 kezhenxu94 merged commit c0ab882 into apache:master Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants