Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query and dispatch ProfileTaskCommand #127

Merged
merged 11 commits into from
Jul 12, 2021
Merged

Query and dispatch ProfileTaskCommand #127

merged 11 commits into from
Jul 12, 2021

Conversation

Humbertzhang
Copy link
Member

@Humbertzhang Humbertzhang commented Jul 11, 2021

This is PR is for Google Summer Of Code 2021 Project: Proposal for Apache SkyWalking: Python agent supports profiling

Add query and dispatch part of ProfileTaskCommand, mainly includes those steps:

1. query ProfileTaskCommand from OAPServer.
2. deserialize command to object
3. dispatch it to appropriate CommandExecutor, here is ProfileTaskCommandExecutor
4. check the ProfileTask's attributes is rational and add it in profile task queue

It uses two threads to complete the task: QueryProfileCommandThread for query and CommandDispatchThread for command dispatch and check.

This PR is the first part of apache/skywalking#5943. I will add the execute part and tests for profiling feature in following PRs.

@Humbertzhang Humbertzhang added this to the 0.7.0 milestone Jul 11, 2021
@Humbertzhang Humbertzhang requested a review from kezhenxu94 July 11, 2021 11:45
@kezhenxu94 kezhenxu94 added the feature New feature label Jul 11, 2021
docs/EnvVars.md Outdated Show resolved Hide resolved
@wu-sheng
Copy link
Member

Is there going to another PR to execute the profiling task, get snapshots and report to OAP?

@Humbertzhang
Copy link
Member Author

Is there going to another PR to execute the profiling task, get snapshots and report to OAP?

Yes, I will add those in next PR

Copy link
Member

@kezhenxu94 kezhenxu94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants