Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scaling when using ingress-addressed nodes #692

Merged
merged 8 commits into from
Apr 3, 2024

Conversation

HoustonPutman
Copy link
Contributor

@HoustonPutman HoustonPutman commented Mar 7, 2024

Fixes #682

This PR does two major things that fixes scaling issues with ingress-addressed node SolrClouds.

  • Whenever a cluster is scaled down, the hostAliases that given to the Solr Pods are not updated. The hostAliases are only changed if a new host alias is added or an existing host alias is changed. There's no need to do a rolling restart to remove a host alias that will no longer be used.
  • When a cluster is scaled up, the hostAliases must be updated to include the new pods. This requires a rolling restart, which we want to occur before trying to rebalance the cluster, since the new pods need to be addressable from the old pods (which the rolling restart will enable). Therefore its best to wait to scale until the rolling restart is complete.

Copy link
Contributor

@gerlowskija gerlowskija left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@HoustonPutman HoustonPutman merged commit 1cc55ef into apache:main Apr 3, 2024
3 checks passed
@HoustonPutman HoustonPutman deleted the ingress-scaling branch April 3, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shards in a down state after an HPA scale up / scale down event.
2 participants