SOLR-16415: ZK DistributedMap should reject slash in IDs. #1824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* asyncId should not have forward slashes in it * SizeLimitedDistributedMap should be resilient to directories (from before)
|
@patsonluk you may be interested based on your previous modifications |
|
I'll merge this Monday if I hear no further feedback. We've been using this in production and it's been peer reviewed. |
# Conflicts: # solr/CHANGES.txt
dsmiley
added a commit
that referenced
this pull request
Sep 11, 2023
* asyncId should not have forward slashes in it * SizeLimitedDistributedMap should be resilient to directories (from before)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SOLR-16415
From what I see, this will work for both Overseer & Distributed Admin API modes. The latter is processed by DistributedApiAsyncTracker and it uses DistributedMap and that's what this PR touches.