Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SOLR-16954 Make Circuit Breakers available for Update Requests #1871

Merged
merged 1 commit into from
Sep 6, 2023
Merged

SOLR-16954 Make Circuit Breakers available for Update Requests #1871

merged 1 commit into from
Sep 6, 2023

Conversation

janhoy
Copy link
Contributor

@janhoy janhoy commented Aug 29, 2023

@janhoy janhoy force-pushed the circuit-breaker-for-update branch from 1e2bc30 to 77d9817 Compare August 30, 2023 07:51
@janhoy janhoy requested review from dsmiley and atris August 30, 2023 07:51
@janhoy
Copy link
Contributor Author

janhoy commented Aug 30, 2023

@dsmiley This is the pr for update request circuit breaking. Please have a look.

@janhoy janhoy mentioned this pull request Aug 30, 2023
Merged
7 tasks
@janhoy janhoy force-pushed the circuit-breaker-for-update branch from 8d30678 to 5b5e613 Compare September 3, 2023 22:27
@janhoy
Copy link
Contributor Author

janhoy commented Sep 4, 2023

@dsmiley Preparing to merge this, please weigh in with experience from similar work in your private fork.

@janhoy
Copy link
Contributor Author

janhoy commented Sep 5, 2023

Will merge this tomorrow Wednesday unless more feedback.

cpoerschke
cpoerschke reviewed Sep 5, 2023
View reviewed changes
solr/CHANGES.txt Show resolved Hide resolved
solr/core/src/java/org/apache/solr/handler/component/SearchHandler.java Outdated Show resolved Hide resolved
solr/core/src/java/org/apache/solr/handler/ContentStreamHandlerBase.java Outdated Show resolved Hide resolved
solr/core/src/java/org/apache/solr/util/circuitbreaker/CircuitBreaker.java Show resolved Hide resolved
solr/solr-ref-guide/modules/deployment-guide/pages/circuit-breakers.adoc Outdated Show resolved Hide resolved
solr/solr-ref-guide/modules/deployment-guide/pages/circuit-breakers.adoc Outdated Show resolved Hide resolved
solr/core/src/test/org/apache/solr/util/BaseTestCircuitBreaker.java Outdated Show resolved Hide resolved
solr/core/src/test/org/apache/solr/util/BaseTestCircuitBreaker.java Outdated Show resolved Hide resolved
solr/core/src/test/org/apache/solr/util/BaseTestCircuitBreaker.java Outdated Show resolved Hide resolved
@janhoy
Copy link
Contributor Author

janhoy commented Sep 6, 2023

Thanks for the attention to detail @cpoerschke. Accepted all your edits. Will merge today.

@cpoerschke
Copy link
Contributor

Hmm, precommit failed with run the top-level './gradlew tidy' to format code automatically (see help/formatting.txt for more info). advisory -- independent of this pull request really, I wonder how practical it might be for the CI to action on that independently i.e. to just run the tidy itself and add a commit to the PR.

@janhoy janhoy force-pushed the circuit-breaker-for-update branch from d778b2e to e6e1076 Compare September 6, 2023 10:22
@janhoy janhoy merged commit abbc695 into apache:main Sep 6, 2023
2 checks passed
@janhoy janhoy deleted the circuit-breaker-for-update branch September 6, 2023 13:35
janhoy added a commit that referenced this pull request Sep 6, 2023
@janhoy
SOLR-16954 Make Circuit Breakers available for Update Requests (#1871)
945d4a3 
Co-authored-by: Christine Poerschke <cpoerschke@apache.org>
(cherry picked from commit abbc695)
justinrsweeney pushed a commit to cowpaths/fullstory-solr that referenced this pull request Nov 2, 2023
@janhoy
SOLR-16954 Make Circuit Breakers available for Update Requests (apach…
d1cf8c8 
…e#1871)

Co-authored-by: Christine Poerschke <cpoerschke@apache.org>
(cherry picked from commit abbc695)
justinrsweeney pushed a commit to cowpaths/fullstory-solr that referenced this pull request Apr 26, 2024
@janhoy
SOLR-16954 Make Circuit Breakers available for Update Requests (apach…
8ac062d 
…e#1871)

Co-authored-by: Christine Poerschke <cpoerschke@apache.org>
(cherry picked from commit abbc695)
nginthfs pushed a commit to cowpaths/fullstory-solr that referenced this pull request May 22, 2024
@janhoy @nginthfs
SOLR-16954 Make Circuit Breakers available for Update Requests (apach…
aea554d 
…e#1871)

Co-authored-by: Christine Poerschke <cpoerschke@apache.org>
(cherry picked from commit abbc695)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psalagnac psalagnac psalagnac approved these changes

@cpoerschke cpoerschke cpoerschke approved these changes

@dsmiley dsmiley Awaiting requested review from dsmiley

@atris atris Awaiting requested review from atris

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@janhoy @cpoerschke @psalagnac