Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SOLR-17578: Remove ZkController internal core supplier. #2891

Merged
merged 3 commits into from
Dec 11, 2024
Merged

SOLR-17578: Remove ZkController internal core supplier. #2891

merged 3 commits into from
Dec 11, 2024

Conversation

psalagnac
Copy link
Contributor

https://issues.apache.org/jira/browse/SOLR-17578

Description

Code to list cores when re-restablishing Zookeeper session is bloated.

Solution

Remove the bloated code and replace it by calls to getCoreDescriptors().

Tests

Checklist

Please review the following and check all that apply:

  • I have reviewed the guidelines for How to Contribute and my code conforms to the standards described there to the best of my ability.
  • I have created a Jira issue and added the issue ID to my pull request title.
  • I have given Solr maintainers access to contribute to my PR branch. (optional but recommended, not available for branches on forks living under an organisation)
  • I have developed this patch against the main branch.
  • I have run ./gradlew check.
  • I have added tests for my changes.
  • I have added documentation for the Reference Guide

HoustonPutman
HoustonPutman approved these changes Dec 2, 2024
View reviewed changes
Copy link
Contributor

@HoustonPutman HoustonPutman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me, just changing the supplier to cc.getCoreDescriptors(). It does assume that is never null, but it looks like that is a fine assumption.

@psalagnac psalagnac merged commit b2f8b10 into apache:main Dec 11, 2024
3 checks passed
@psalagnac psalagnac deleted the no-supplier branch December 11, 2024 10:54
psalagnac added a commit that referenced this pull request Dec 11, 2024
@psalagnac
SOLR-17578: Remove ZkController internal core supplier. (#2891)
36ab960 
(cherry picked from commit b2f8b10)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HoustonPutman HoustonPutman HoustonPutman approved these changes

@dsmiley dsmiley dsmiley approved these changes

Assignees
No one assigned
Labels
cat:cloud tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@psalagnac @dsmiley @HoustonPutman