Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SOLR-17579: Refactoring suggested by IDE in ReplicationHandler and tests #2893

Merged
merged 5 commits into from
Dec 14, 2024
Merged

SOLR-17579: Refactoring suggested by IDE in ReplicationHandler and tests #2893

merged 5 commits into from
Dec 14, 2024
+40 −77

Conversation

epugh
Copy link
Contributor

@epugh epugh commented Dec 2, 2024

Typos, some dead methods and dead variables.

https://issues.apache.org/jira/browse/SOLR-17579

Description

Intellij suggested some fixes.

Solution

Do them and run tests

Tests

existing

@epugh
Refactoring suggested by IDE.
51c34fa 
Typos, some dead methods and dead variables.
@github-actions github-actions bot added the tests label Dec 2, 2024
malliaridis
malliaridis reviewed Dec 6, 2024
View reviewed changes
Copy link
Contributor

@malliaridis malliaridis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure if it is fine to remove the public static final field LOCAL_ACTIVITY_DURING_REPLICATION, but besides that, everything else looks fine.

The assertion was a great finding though.

@epugh epugh merged commit 024f973 into apache:main Dec 14, 2024
2 of 3 checks passed
epugh added a commit that referenced this pull request Dec 14, 2024
@epugh
SOLR-17579: Refactoring suggested by IDE in ReplicationHandler and te…
51275fd 
…sts (#2893)

* Refactoring suggested by IDE.
* Typos, some dead methods and dead variables.

(cherry picked from commit 024f973)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malliaridis malliaridis malliaridis left review comments

Assignees
No one assigned
Labels
tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@epugh @malliaridis