Allow lsof and sockstat to detect if solr started successfully #2906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tool lsof is not available on all system, like FreeBSD. Added the possibility to use sockstat to detect if solr started successfully. The startup script is using the tool that is available.
freebsd-git
pushed a commit
to freebsd/freebsd-ports
that referenced
this pull request
Dec 13, 2024
While starting solr it is using now sockstat and can detect now if the start was successful. The patch is also provided upstream here: apache/solr#2906 Thanks a lot freebsd@koenigbj.8bx.de to provide with the required sockstat parameters to make this PR possible. PR: 283270
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tool lsof is not available on all systems, like FreeBSD.
Added the possibility to use sockstat to detect if solr started successfully.
The startup script is using the tool that is available.
https://issues.apache.org/jira/browse/SOLR-17594
Description
Allow the startup script to use lsof or sockstat to detect if solr was started successfully
Solution
The script checks at first if lsof is available than if sockstat is available and than fallback to standard behaviour.
Tests
I tested the patch on FreeBSD and will also commit the patch after the PR is created with a link to it.
Checklist
Please review the following and check all that apply:
mainbranch../gradlew check.