[SPARK-28894][SQL][TESTS] Add a clue to make it easier to debug via Jenkins's test results

[HyukjinKwon]

What changes were proposed in this pull request?

See https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/109834/testReport/junit/org.apache.spark.sql/SQLQueryTestSuite/

<?xml version="1.0" encoding="UTF-8"?>
<testsuite hostname="C02Y52ZLJGH5" name="org.apache.spark.sql.SQLQueryTestSuite" tests="3" errors="0" failures="0" skipped="0" time="14.475">
    ...
    <testcase classname="org.apache.spark.sql.SQLQueryTestSuite" name="sql - Scala UDF" time="6.703">
    </testcase>
    <testcase classname="org.apache.spark.sql.SQLQueryTestSuite" name="sql - Regular Python UDF" time="4.442">
    </testcase>
    <testcase classname="org.apache.spark.sql.SQLQueryTestSuite" name="sql - Scalar Pandas UDF" time="3.33">
    </testcase>
    <system-out/>
    <system-err/>
</testsuite>

Root cause seems a bug in SBT - it truncates the test name based on the last dot.

sbt/sbt#2949
https://github.com/sbt/sbt/blob/v0.13.18/testing/src/main/scala/sbt/JUnitXmlTestsListener.scala#L71-L79

I tried to find a better way but couldn't find. Therefore, this PR proposes a workaround by appending the test file name into the assert log:

  [info] - inner-join.sql *** FAILED *** (4 seconds, 306 milliseconds)
+ [info]   inner-join.sql
  [info]   Expected "1	a
  [info]   1	a
  [info]   1	b
  [info]   1[]", but got "1	a
  [info]   1	a
  [info]   1	b
  [info]   1[	b]" Result did not match for query #6
  [info]   SELECT tb.* FROM ta INNER JOIN tb ON ta.a = tb.a AND ta.tag = tb.tag (SQLQueryTestSuite.scala:377)
  [info]   org.scalatest.exceptions.TestFailedException:
  [info]   at org.scalatest.Assertions.newAssertionFailedException(Assertions.scala:528)

It will at least prevent us to search full logs to identify which test file is failed by clicking filed test.

Note that this PR does not fully fix the issue but only fix the logs on its failed tests.

Why are the changes needed?

To debug Jenkins logs easier. Otherwise, we should open full logs and search which test was failed.

Does this PR introduce any user-facing change?

It will print out the file name of failed tests in Jenkins' test reports.

How was this patch tested?

Manually tested but Jenkins tests are required in this PR.

Now it at least shows which file it is:

[HyukjinKwon]

I am going to revert 28e7f2f after we see the test results. It's for testing if the failed tests really have the file name in its assert message.

[HyukjinKwon]

cc @dilipbiswal, @dongjoon-hyun, @maryannxue FYI

[HyukjinKwon]

Actual change is just:

withClue(s"${testCase.name}${System.lineSeparator()}") {
  ...
}

[SparkQA]

Test build #109942 has finished for PR 25630 at commit 28e7f2f.

• This patch fails Spark unit tests.
• This patch merges cleanly.
• This patch adds no public classes.

[SparkQA]

Test build #109951 has finished for PR 25630 at commit a3c73c8.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.

[dongjoon-hyun]

It seems that it still has the same title sql~

• https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/109951/testReport/org.apache.spark.sql/SQLQueryTestSuite/

[HyukjinKwon]

Yes but the log on failure test has its file name now -

I tried to find a better way but couldn't find to fix in Jenkins or SBT. This PR proposes a workaround by appending the test file name into the assert log as I described in PR description.

[dilipbiswal]

@HyukjinKwon Its much better than what we had before. thanks !! Looks good to me.

[dongjoon-hyun]

Got it. It's much better! So, in the successful run, there is no information in the last Jenkins. When we have a failure, Error Message will have that information. Did I understand correctly?

[dongjoon-hyun]

I compared both results. +1, LGTM.

[dongjoon-hyun]

Thank you, @HyukjinKwon and @dilipbiswal .
Merged to master!

[HyukjinKwon]

Thanks!