-
Notifications
You must be signed in to change notification settings - Fork 28.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-48049][BUILD] Upgrade Scala to 2.13.14 #46288
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow. Nice timing. Thank you, @panbingkun !
Like we observed before, I guess we need to wait new compatible plugins and cc @LuciferYang , too |
Yeah, that's right. 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the record, this is blocked by
Thank you so much, @SethTisue ! |
Although we are waiting for |
Sure, done. |
I have updated the version of |
Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a question. CI seems to complain the following. Is this related to this PR?
Error: Failed to execute goal org.apache.maven.plugins:maven-enforcer-plugin:3.4.1:enforce (enforce-versions) on project spark-tools_2.13:
Error: Rule 3: org.codehaus.mojo.extraenforcer.dependencies.EnforceBytecodeVersion failed with message:
Error: Found Banned Dependency: org.jline:jline:jar:3.25.1
connector/connect/client/jvm/pom.xml
Outdated
@@ -73,7 +73,7 @@ | |||
</dependency> | |||
<dependency> | |||
<groupId>com.lihaoyi</groupId> | |||
<artifactId>ammonite_${scala.version}</artifactId> | |||
<artifactId>ammonite_2.13.13</artifactId> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only for test
After the Ammonite
supports scala 2.13.14
, I will restore it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it's merged ten minutes ago. Looking forward to seeing the new release.
Although we already use
|
@SethTisue I found that in But I found that Thank you! |
https://github.com/jline/jline3/blob/c75301facc8716b59c1d57d3e3c5943358022560/pom.xml#L93-L95 https://github.com/jline/jline3/blob/c75301facc8716b59c1d57d3e3c5943358022560/pom.xml#L422-L434 The release version of |
[INFO] Restricted to JDK 17 yet org.jline:jline:jar:3.25.1:compile contains org/jline/terminal/impl/ffm/CLibrary$termios.class targeted to 65.-257 Oh... It seems that In jline 3.25.1, CLibrary references some implementations that were moved to the However, in jline 3.24.1, CLibrary also import classes in So it seems that using jline 3.25.1 should not pose any issues. It's unclear whether it's possible to workaround this by modifying the rules of the |
@dongjoon-hyun @LuciferYang |
@dongjoon-hyun @LuciferYang and
2.When open
3.The code logic of When loading
so we can |
@@ -2981,6 +2981,9 @@ | |||
<maxJdkVersion>${java.version}</maxJdkVersion> | |||
<ignoredScopes>test</ignoredScopes> | |||
<ignoredScopes>provided</ignoredScopes> | |||
<ignoreClasses> | |||
<ignoreClass>org.jline.terminal.impl.ffm.*</ignoreClass> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a comment with the pointer scala/bug#12994 .
Thank you, @panbingkun . |
|
I use this version |
This seems to be a snapshot or test version, not an official release? |
I have asked the community to release an official version for us at his convenience |
Thank you for confirming. Ya, let's wait. |
https://github.com/com-lihaoyi/Ammonite/releases/tag/3.0.0-M2 3.0.0-M2 released ~ @panbingkun |
Thanks~ ❤️ |
project/SparkBuild.scala
Outdated
@@ -266,7 +266,7 @@ object SparkBuild extends PomBuild { | |||
.orElse(sys.props.get("java.home").map { p => new File(p).getParentFile().getAbsolutePath() }) | |||
.map(file), | |||
publishMavenStyle := true, | |||
unidocGenjavadocVersion := "0.18", | |||
unidocGenjavadocVersion := "0.19", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please upgrade GenJavadoc
in a separate pr first. @panbingkun
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
A separate pr for upgrade GenJavadoc
: #46579
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@LuciferYang
I think we can upgrade scala to 2.13.14
only after #46579 is merged.
1.https://mvnrepository.com/artifact/com.typesafe.genjavadoc/genjavadoc-plugin
2.https://github.com/panbingkun/spark/actions/runs/9079936342/job/24951167973
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, LGTM. Thank you, @panbingkun and @LuciferYang and all.
Merged to master for Apache Spark 4.0.0-preview2-rc2.
The pr aims to upgrade `scala` from `2.13.13` to `2.13.14`. https://github.com/scala/scala/releases/tag/v2.13.14 <img width="984" alt="image" src="https://github.com/apache/spark/assets/15246973/179274bf-11c0-472c-a6b6-217b9904832d"> No. Pass GA. No. Closes apache#46288 from panbingkun/SPARK-48049. Authored-by: panbingkun <panbingkun@baidu.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
What changes were proposed in this pull request?
The pr aims to upgrade
scala
from2.13.13
to2.13.14
.Why are the changes needed?
https://github.com/scala/scala/releases/tag/v2.13.14
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass GA.
Was this patch authored or co-authored using generative AI tooling?
No.