[SPARK-47579][CORE][PART3] Spark core: Migrate logInfo with variables to structured logging framework #46739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cloud-fan
approved these changes
May 24, 2024
dongjoon-hyun
approved these changes
May 24, 2024
|
Pending CIs. |
|
@cloud-fan @dongjoon-hyun thanks for the review. |
panbingkun
reviewed
May 26, 2024
core/src/main/scala/org/apache/spark/scheduler/dynalloc/ExecutorMonitor.scala
Show resolved
Hide resolved
gengliangwang
pushed a commit
that referenced
this pull request
May 26, 2024
### What changes were proposed in this pull request? The pr is following up #46739, and aims to fix `KubernetesSuite `. 1.Unfortunately, after `correcting` the `typo` from `decommision` to `decommission`, it seems that GA has been broken. <img width="971" alt="image" src="https://github.com/apache/spark/assets/15246973/6212debb-0ff6-4d22-8999-e37aa2cb2c10"> 2.https://github.com/panbingkun/spark/actions/runs/9232744348/job/25406127982 <img width="925" alt="image" src="https://github.com/apache/spark/assets/15246973/4e71598c-22f3-4fd2-afba-fd91ddce5f55"> ### Why are the changes needed? Only fix `KubernetesSuite`. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass GA. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #46746 from panbingkun/fix_KubernetesSuite. Authored-by: panbingkun <panbingkun@baidu.com> Signed-off-by: Gengliang Wang <gengliang@apache.org>
riyaverm-db
pushed a commit
to riyaverm-db/spark
that referenced
this pull request
Jun 7, 2024
… to structured logging framework ### What changes were proposed in this pull request? The PR aims to migrate logInfo in Core module with variables to structured logging framework. ### Why are the changes needed? To enhance Apache Spark's logging system by implementing structured logging. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? GA tests ### Was this patch authored or co-authored using generative AI tooling? Yes, Generated-by: Github Copilot Github Copilot provides a few suggestions. Closes apache#46739 from gengliangwang/logInfoCoreP3. Authored-by: Gengliang Wang <gengliang@apache.org> Signed-off-by: Gengliang Wang <gengliang@apache.org>
riyaverm-db
pushed a commit
to riyaverm-db/spark
that referenced
this pull request
Jun 7, 2024
### What changes were proposed in this pull request? The pr is following up apache#46739, and aims to fix `KubernetesSuite `. 1.Unfortunately, after `correcting` the `typo` from `decommision` to `decommission`, it seems that GA has been broken. <img width="971" alt="image" src="https://github.com/apache/spark/assets/15246973/6212debb-0ff6-4d22-8999-e37aa2cb2c10"> 2.https://github.com/panbingkun/spark/actions/runs/9232744348/job/25406127982 <img width="925" alt="image" src="https://github.com/apache/spark/assets/15246973/4e71598c-22f3-4fd2-afba-fd91ddce5f55"> ### Why are the changes needed? Only fix `KubernetesSuite`. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass GA. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#46746 from panbingkun/fix_KubernetesSuite. Authored-by: panbingkun <panbingkun@baidu.com> Signed-off-by: Gengliang Wang <gengliang@apache.org>
gengliangwang
added a commit
that referenced
this pull request
Jun 17, 2024
### What changes were proposed in this pull request? Correct misleading usage of log key TASK_ID from #45834 and #46739 ### Why are the changes needed? Provide more accurate log keys in the structure logging ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Existing GA tests ### Was this patch authored or co-authored using generative AI tooling? No Closes #46951 from gengliangwang/fixTaskId. Authored-by: Gengliang Wang <gengliang@apache.org> Signed-off-by: Gengliang Wang <gengliang@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The PR aims to migrate logInfo in Core module with variables to structured logging framework.
Why are the changes needed?
To enhance Apache Spark's logging system by implementing structured logging.
Does this PR introduce any user-facing change?
No
How was this patch tested?
GA tests
Was this patch authored or co-authored using generative AI tooling?
Yes, Generated-by: Github Copilot
Github Copilot provides a few suggestions.