[SPARK-49713][PYTHON][FOLLOWUP] Make function count_min_sketch accept long seed
#48223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhengruifeng
requested review from
HyukjinKwon,
dongjoon-hyun and
xinrong-meng
HyukjinKwon
approved these changes
Sep 24, 2024
|
Merged to master. |
attilapiros
pushed a commit
to attilapiros/spark
that referenced
this pull request
Oct 4, 2024
…pt long seed
### What changes were proposed in this pull request?
Make function `count_min_sketch` accept long seed
### Why are the changes needed?
existing implementation only accepts int seed, which is inconsistent with other `ExpressionWithRandomSeed`:
```py
In [3]: >>> from pyspark.sql import functions as sf
...: >>> spark.range(100).select(
...: ... sf.hex(sf.count_min_sketch("id", sf.lit(1.5), 0.6, 1111111111111111111))
...: ... ).show(truncate=False)
...
AnalysisException: [DATATYPE_MISMATCH.UNEXPECTED_INPUT_TYPE] Cannot resolve "count_min_sketch(id, 1.5, 0.6, 1111111111111111111)" due to data type mismatch: The 4th parameter requires the "INT" type, however "1111111111111111111" has the type "BIGINT". SQLSTATE: 42K09;
'Aggregate [unresolvedalias('hex(count_min_sketch(id#64L, 1.5, 0.6, 1111111111111111111, 0, 0)))]
+- Range (0, 100, step=1, splits=Some(12))
...
```
### Does this PR introduce _any_ user-facing change?
no
### How was this patch tested?
added doctest
### Was this patch authored or co-authored using generative AI tooling?
no
Closes apache#48223 from zhengruifeng/count_min_sk_long_seed.
Authored-by: Ruifeng Zheng <ruifengz@apache.org>
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
himadripal
pushed a commit
to himadripal/spark
that referenced
this pull request
Oct 19, 2024
…pt long seed
### What changes were proposed in this pull request?
Make function `count_min_sketch` accept long seed
### Why are the changes needed?
existing implementation only accepts int seed, which is inconsistent with other `ExpressionWithRandomSeed`:
```py
In [3]: >>> from pyspark.sql import functions as sf
...: >>> spark.range(100).select(
...: ... sf.hex(sf.count_min_sketch("id", sf.lit(1.5), 0.6, 1111111111111111111))
...: ... ).show(truncate=False)
...
AnalysisException: [DATATYPE_MISMATCH.UNEXPECTED_INPUT_TYPE] Cannot resolve "count_min_sketch(id, 1.5, 0.6, 1111111111111111111)" due to data type mismatch: The 4th parameter requires the "INT" type, however "1111111111111111111" has the type "BIGINT". SQLSTATE: 42K09;
'Aggregate [unresolvedalias('hex(count_min_sketch(id#64L, 1.5, 0.6, 1111111111111111111, 0, 0)))]
+- Range (0, 100, step=1, splits=Some(12))
...
```
### Does this PR introduce _any_ user-facing change?
no
### How was this patch tested?
added doctest
### Was this patch authored or co-authored using generative AI tooling?
no
Closes apache#48223 from zhengruifeng/count_min_sk_long_seed.
Authored-by: Ruifeng Zheng <ruifengz@apache.org>
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Make function
count_min_sketchaccept long seedWhy are the changes needed?
existing implementation only accepts int seed, which is inconsistent with other
ExpressionWithRandomSeed:Does this PR introduce any user-facing change?
no
How was this patch tested?
added doctest
Was this patch authored or co-authored using generative AI tooling?
no