[SPARK-49814][CONNECT] When Spark Connect Client starts, show the spark version of the connect server
#48283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rk version of the connect server
|
cc @HyukjinKwon |
HyukjinKwon
approved these changes
Sep 28, 2024
|
Merged to master. |
attilapiros
pushed a commit
to attilapiros/spark
that referenced
this pull request
Oct 4, 2024
…ark version` of the `connect server` ### What changes were proposed in this pull request? The pr aims to show the spark version of the connect server when Spark Connect Client starts. ### Why are the changes needed? With the gradual popularize of Spark Connect module, when the Spark Connect client starts, explicitly displaying the spark version of the `connect server`, will reduce confusion for users during execution, such as the new version having some features. However, if it connects to an old version and encounters some problems, it will have to manually troubleshoot. <img width="878" alt="image" src="https://github.com/user-attachments/assets/c93026e8-03e7-4292-bae2-c3a0f4422191"> ### Does this PR introduce _any_ user-facing change? Yes, Connect‘s end-users can intuitively know the `Spark version` on the `server side` when starting the client, reducing confusion. ### How was this patch tested? Manually check. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#48283 from panbingkun/SPARK-49814. Authored-by: panbingkun <panbingkun@baidu.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
himadripal
pushed a commit
to himadripal/spark
that referenced
this pull request
Oct 19, 2024
…ark version` of the `connect server` ### What changes were proposed in this pull request? The pr aims to show the spark version of the connect server when Spark Connect Client starts. ### Why are the changes needed? With the gradual popularize of Spark Connect module, when the Spark Connect client starts, explicitly displaying the spark version of the `connect server`, will reduce confusion for users during execution, such as the new version having some features. However, if it connects to an old version and encounters some problems, it will have to manually troubleshoot. <img width="878" alt="image" src="https://github.com/user-attachments/assets/c93026e8-03e7-4292-bae2-c3a0f4422191"> ### Does this PR introduce _any_ user-facing change? Yes, Connect‘s end-users can intuitively know the `Spark version` on the `server side` when starting the client, reducing confusion. ### How was this patch tested? Manually check. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#48283 from panbingkun/SPARK-49814. Authored-by: panbingkun <panbingkun@baidu.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The pr aims to show the spark version of the connect server when Spark Connect Client starts.
Why are the changes needed?
With the gradual popularize of Spark Connect module, when the Spark Connect client starts, explicitly displaying the spark version of the
connect server, will reduce confusion for users during execution, such as the new version having some features. However, if it connects to an old version and encounters some problems, it will have to manually troubleshoot.Does this PR introduce any user-facing change?
Yes, Connect‘s end-users can intuitively know the
Spark versionon theserver sidewhen starting the client, reducing confusion.How was this patch tested?
Manually check.
Was this patch authored or co-authored using generative AI tooling?
No.