Merge pull request #570 from apache/WW-5187-velocity

[WW-5187] Comments out Velocity based PageFilter
apache · Jun 17, 2022 · dc4e403 · dc4e403
2 parents e6bc93d + fc2aebd
commit dc4e403
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/plugins/sitemesh/src/main/java/org/apache/struts2/sitemesh/VelocityPageFilter.java b/plugins/sitemesh/src/main/java/org/apache/struts2/sitemesh/VelocityPageFilter.java
@@ -50,7 +50,7 @@ protected DecoratorSelector initDecoratorSelector(SiteMeshWebAppContext webAppCo
         // TODO: Remove heavy coupling on horrible SM2 Factory
         Factory factory = Factory.getInstance(new Config(filterConfig));
         factory.refresh();
-        return new FreemarkerMapper2DecoratorSelector(factory.getDecoratorMapper());
+        return new VelocityMapper2DecoratorSelector(factory.getDecoratorMapper());
     }
 
 }

diff --git a/plugins/sitemesh/src/main/resources/struts-plugin.xml b/plugins/sitemesh/src/main/resources/struts-plugin.xml
@@ -22,8 +22,9 @@
 <!DOCTYPE struts PUBLIC
 	"-//Apache Software Foundation//DTD Struts Configuration 2.5//EN"
 	"http://struts.apache.org/dtds/struts-2.5.dtd">
-    
+
 <struts>
     <bean class="org.apache.struts2.sitemesh.FreemarkerPageFilter" static="true" optional="true"/>
-    <bean class="org.apache.struts2.sitemesh.VelocityPageFilter" static="true" optional="true"/>
+    <!-- if you want to use Velocity with Sitemesh, please define this bean in your struts.xml -->
+    <!-- bean class="org.apache.struts2.sitemesh.VelocityPageFilter" static="true" optional="true"/ -->
 </struts>