[WW-4620] Improve XWorkListPropertyAccessor to against DOS attack #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -36,6 +36,7 @@ | |||
| * this class will create the necessary blank JavaBeans. | |||
| * | |||
| * @author Gabriel Zimmerman | |||
| * @author Yanming Zhou <zhouyanming@gmail.com> | |||
There was a problem hiding this comment.
Please remove author tag. In general you should refrain from doing so. Why? Because.
| @@ -45,6 +45,12 @@ | |||
| private ObjectFactory objectFactory; | |||
| private ObjectTypeDeterminer objectTypeDeterminer; | |||
| private OgnlUtil ognlUtil; | |||
| private int autoGrowCollectionLimit = 255; | |||
|
|
|||
| @Inject(value="java.util.Collection.autoGrowCollectionLimit", required = false) | |||
There was a problem hiding this comment.
Is it a predefined constant? I mean, does it exist somewhere?
There was a problem hiding this comment.
It doesn't exists anywhere else.
There was a problem hiding this comment.
Hmm... I would add struts. prefix, though. The name suggests that it is something Java specific.
There was a problem hiding this comment.
It's OK.
Do you mean you will change this?
There was a problem hiding this comment.
I changed it with prefix "xwork"
|
ping :) |
I think prefix "xwork" better than "struts"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.