Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WW-4694] annotation processing improved #117

Merged
merged 2 commits into from
Feb 13, 2017
Merged

Conversation

yasserzamani
Copy link
Member

With these changes, AnnotationUtils can navigate around proxies, superclasses and interfaces.
known issue: for keep it simple, currently it does not support Bridge Methods.

@lukaszlenart
Copy link
Member

I have one general issue: indentation in some files are too big, it should be 4 spaces

@yasserzamani
Copy link
Member Author

Thank you. I got it and will fix it by update my eclipse Preferences.

And what about the new codes and comments? some of them are copied from Spring framework which itself has Apache License 2.0 license like Struts2. Do you recommend to rewrite them to something different with same functionality or no, those do not cause any legal issues?

And finally, these changes are needed to fix [WW-4472]. Could you please add this issue id to the title to automatically linking and resolving that issue too?

Thanks in advance!

@lukaszlenart
Copy link
Member

Cool, this look great and I don't mind copping code from other libraries if they match license :)

Regarding issue linkage I think you can update the description and put an issue ID there, e.g. Fixes WW-4472 should be enough

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants