Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WW-4849: Initializable interface #168

Merged
merged 6 commits into from
Oct 6, 2017
Merged

WW-4849: Initializable interface #168

merged 6 commits into from
Oct 6, 2017

Conversation

lukaszlenart
Copy link
Member

Fixes WW-4849

@aleksandr-m
Copy link
Contributor

Works in my simple test project. I'll try to test it in more complex project tomorrow.

@gstein
Copy link
Member

gstein commented Sep 27, 2017

Closing and re-opening, per @lukaszlenart.

@gstein gstein closed this Sep 27, 2017
@gstein gstein reopened this Sep 27, 2017
@aleksandr-m
Copy link
Contributor

@lukaszlenart Seems to be working. Good job!

@lukaszlenart
Copy link
Member Author

@aleksandr-m great, I will give few more days others to post a comment :)

@yasserzamani
Copy link
Member

Nice work! I added some logs and compared S2.5.12 with this PR:

S2.5.12 vs PR168

@lukaszlenart
Copy link
Member Author

Thanks a lot, I think we can merge this in and start thinking about another release to fill the gap :)

@lukaszlenart
Copy link
Member Author

Closes #165

@lukaszlenart lukaszlenart merged commit 4ce603b into apache:master Oct 6, 2017
@lukaszlenart lukaszlenart deleted the initializable branch October 6, 2017 05:56
@yasserzamani yasserzamani mentioned this pull request Nov 12, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lukaszlenart @aleksandr-m @gstein @yasserzamani