-
Notifications
You must be signed in to change notification settings - Fork 811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial test dedicated for the DefaultUnknownHandlerManager #205
Changes from 2 commits
4918f3c
61fb20f
8111fbf
820d18d
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,84 @@ | ||
/* | ||
* Licensed to the Apache Software Foundation (ASF) under one | ||
* or more contributor license agreements. See the NOTICE file | ||
* distributed with this work for additional information | ||
* regarding copyright ownership. The ASF licenses this file | ||
* to you under the Apache License, Version 2.0 (the | ||
* "License"); you may not use this file except in compliance | ||
* with the License. You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, | ||
* software distributed under the License is distributed on an | ||
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
* KIND, either express or implied. See the License for the | ||
* specific language governing permissions and limitations | ||
* under the License. | ||
*/ | ||
package com.opensymphony.xwork2; | ||
|
||
import com.opensymphony.xwork2.config.entities.ActionConfig; | ||
import com.opensymphony.xwork2.config.providers.SomeUnknownHandler; | ||
|
||
import java.util.ArrayList; | ||
|
||
/** | ||
* Partial test to the DefaultUnknownHandlerManager to understand the relationship between Manager and Handlers. | ||
* | ||
*/ | ||
public class DefaultUnknownHandlerManagerTest extends XWorkTestCase { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I tested There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I was following other test cases here. I will change it and push it if tests pass. |
||
|
||
ActionConfig.Builder actionConfigBuilder = new ActionConfig.Builder( "com", "someAction", "someClass"); | ||
ActionConfig actionConfig = actionConfigBuilder.build(); | ||
SomeUnknownHandler someUnknownHandler = new SomeUnknownHandler(); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It's a good practice to initialise such things in There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. you are right, fixed. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👍 |
||
|
||
/** | ||
* Relationshsip when UnknownAction method is called. | ||
* | ||
*/ | ||
public void testHandleUnknownAction() { | ||
|
||
DefaultUnknownHandlerManager defaultUnknownHandlerManager = new DefaultUnknownHandlerManager(); | ||
defaultUnknownHandlerManager.unknownHandlers = new ArrayList<>(); | ||
defaultUnknownHandlerManager.unknownHandlers.add(someUnknownHandler); | ||
|
||
ActionConfig newActionConfig = defaultUnknownHandlerManager.handleUnknownAction("arbitraryNameSpace", "arbitraryActionName"); | ||
|
||
assertEquals(newActionConfig, actionConfig); | ||
} | ||
|
||
/** | ||
* Relationship when UnknownActionMethod method called. | ||
* | ||
*/ | ||
public void testHandelUnknownActionMethod() throws Exception { | ||
DefaultUnknownHandlerManager defaultUnknownHandlerManager = new DefaultUnknownHandlerManager(); | ||
defaultUnknownHandlerManager.unknownHandlers = new ArrayList<>(); | ||
defaultUnknownHandlerManager.unknownHandlers.add(someUnknownHandler); | ||
|
||
String result = null; | ||
|
||
for (int i = 0; i < 10 ; i++) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why 10 times? I'm just curious :) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It is an arbitrary number. I wanted to see the difference this will make on what I'm developing. |
||
result = (String) defaultUnknownHandlerManager.handleUnknownMethod(this, "someMethodName"); | ||
assertEquals(result, "specialActionMethod"); | ||
} | ||
|
||
} | ||
|
||
@Override | ||
protected void setUp() throws Exception { | ||
super.setUp(); | ||
|
||
// Make sure we are using the actionConfig we initialized. | ||
someUnknownHandler.setActionConfig(actionConfig); | ||
someUnknownHandler.setActionMethodResult("specialActionMethod"); | ||
} | ||
|
||
@Override | ||
protected void tearDown() throws Exception { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It seems you can downgrade to |
||
super.tearDown(); | ||
|
||
} | ||
|
||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please copy and paste the LICENCE text from a neighbor test .java file to beginning of this file to pass Jenkins build :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, this is clear and fixed.