Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WW-4572 Http parameters #58

Merged
merged 103 commits into from
Jul 15, 2016
Merged

WW-4572 Http parameters #58

merged 103 commits into from
Jul 15, 2016

Conversation

lukaszlenart
Copy link
Member

Implements WW-4572

This PR converts parameters to be represented by a dedicated class - HttpParameters - instead of using a simple Map.

@lukaszlenart
Introduces new class to represent HTTP parameters
6b20fb5
@lukaszlenart
Introduces new class to represent expression evaluation
787f2f9
@lukaszlenart
Uses the class instead of a Map
330a0ed
@lukaszlenart
Uses HttpParameters class instead of a generic Map
5508352
@lukaszlenart
Updates implementation and fixes test
6ad4f9f
@lukaszlenart
Fixes issue with filtering out excluded params
2623559
@lukaszlenart
Adjusts test
8282d60
@lukaszlenart
Updates test
fe1cbc4
@lukaszlenart
Fixes test and cleans up naming
c393a42
@lukaszlenart
Fixes test
2c110e2
@lukaszlenart
Fixes test
fcd407c
@lukaszlenart
Fixes test
b0a2fbc
@lukaszlenart
Fixes test
560f030
@lukaszlenart
Fixes test
b373d6a
@lukaszlenart
Fixes test
1fa8eac
@lukaszlenart
Fixes test
4b8f7b0
@lukaszlenart
Fixes test
6fd94e8
@lukaszlenart
Fixes test
bda06c8
@lukaszlenart
Creates ActionMapping with empty params
8dc6f77
@lukaszlenart
Fixes support for checkboxes
bb115be
@lukaszlenart
Fixes test
48602b8
@lukaszlenart
Fixes test
c14791a
@lukaszlenart
Adjusts interceptor
582bb32
@lukaszlenart
Fixes test
9640c2b
@lukaszlenart
Fixes test
bb096d6
@lukaszlenart
Updates tests
3a0bd4c
@lukaszlenart
Introduces getObject getter to keep compatibility
ce8ac8e
@lukaszlenart
Adjusts usage of parameters
60b9d85
@lukaszlenart
Updates tests
059ebc7
@cnenning
Copy link
Member

As far as I see it, there is no new functionality (like security checks) right now. Currently the code is just refactored to work with new interface/class Parameter and HttpParameters, am I right?

The method Parameter.isExpression() seems not to be used or implemented (ohter than return false)? The new class Evaluated is only used by AliasInterceptor?

This looks promising ...

Beside future things, I have two questions about how things are done right now:

  • It seems to me that currently converters are not used. Now we got Parameter.Request.getValue(). Should converters be used there?
  • My first impression is that that method could be slow, as it could be called quite often. What about caching the result of toStringArray() in a member?

lukaszlenart and others added 21 commits January 19, 2016 16:19
@lukaszlenart
Renames class to match pattern used in Tiles
21a1e8b
@lukaszlenart
Adds missing dependencies to tiles-request
375faa4
@lukaszlenart
Defines helper method to fetch ActionContext from request
4c6e51b
@lukaszlenart
Overrides method to use defined base instead of fetching it again
828b237
@lukaszlenart
Extends logging
e53a119
@lukaszlenart
Simplifies logic to fetch HttpServletRequest
4e36a54
@lukaszlenart
increased visibilty of methods and constants for better extensibility
b0613a6
@rgielen @lukaszlenart
WW-4507 - clone Tomcat UDecoder and use it for in query string handling
76f1884 
(cherry picked from commit 5421930)
@rgielen @lukaszlenart
WW-4507 - adjust Tomcat url decoding code to Log4j 2 logging used in …
4720f46 
…Struts
@rgielen @lukaszlenart
WW-4403 - add JDK 8 profile, disabling JavaDoc lint checker when buil…
50c95d4 
…ding with JDK8

(cherry picked from commit 7c4bb7e)
@rgielen @lukaszlenart
WW-4381 - exclude org.olap4j:olap4j for compile, to fix broken builds…
dd849e8 
… behind Maven mirror
@aleksandr-m @lukaszlenart
WW-4585 Struts2 Rest plugin doesn't handle JSESSIONID with DMI
5eaef08
@lukaszlenart
Uses existing constants instead of literals
6274820
@lukaszlenart
Extracts constants representing expression languages
4771dfa
@lukaszlenart
Adds support to use Struts' Locale
42628da
@lukaszlenart
Adds support for I18N
47c6467
@lukaszlenart
Simplifies logging
8b60785
@lukaszlenart
Merge branch 'master' into http-parameters
abd8c6b 
Conflicts:
	core/src/main/java/com/opensymphony/xwork2/util/CompoundRoot.java
@lukaszlenart
Merge remote-tracking branch 'upstream/master' into http-parameters
bb21dbe 
Conflicts:
	core/src/main/java/com/opensymphony/xwork2/interceptor/ParametersInterceptor.java
	core/src/test/java/com/opensymphony/xwork2/interceptor/I18nInterceptorTest.java
	core/src/test/java/com/opensymphony/xwork2/interceptor/ParameterRemoverInterceptorTest.java
	core/src/test/java/org/apache/struts2/interceptor/MessageStoreInterceptorTest.java
	core/src/test/java/org/apache/struts2/interceptor/ServletConfigInterceptorTest.java
	core/src/test/java/org/apache/struts2/views/jsp/ActionTagTest.java
@lukaszlenart
Drops unused import
31826bc
@lukaszlenart
Fixes test to use HttpParameters instead of Map
b48082a
@ke4qqq
Copy link

ke4qqq commented Mar 25, 2016

Closing and reopening to make sure Travis is working.

@ke4qqq ke4qqq closed this Mar 25, 2016
@ke4qqq ke4qqq reopened this Mar 25, 2016
@lukaszlenart lukaszlenart changed the title Http parameters WW-4572 Http parameters Jul 15, 2016
@asfgit asfgit merged commit 70fdc00 into apache:master Jul 15, 2016
@lukaszlenart lukaszlenart deleted the http-parameters branch July 15, 2016 13:23
@yasserzamani yasserzamani mentioned this pull request Nov 21, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@lukaszlenart @cnenning @ke4qqq @asfgit @aleksandr-m @victorsosa @rgielen