-
Notifications
You must be signed in to change notification settings - Fork 815
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WW-5270 Fix forwarding from Struts excluded URL #648
WW-5270 Fix forwarding from Struts excluded URL #648
Conversation
803833d
to
7c61800
Compare
My initial ThreadLocal based approach to reworking the request cleanup process was not functioning as intended. I've reverted to tracking filter recursion as a request attribute but have still retained the reworked logic. This means:
The implementation is a little confusing at first glance (and was also why I favoured the ThreadLocal based approach) but it's the best I've got right now - open to suggestions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I totally missed this PR, LGTM 👍
@kusalk could you resolve conflicts? I see nothing but GH blocks merging this PR :\ |
7c61800
to
f524dc8
Compare
f524dc8
to
0ce254d
Compare
@lukaszlenart All good, should be sorted now. We shipped this change in Confluence 8.0.2 on Dec 22nd and there have been no reported issues. |
Implements WW-5270