Defines a proper CODEOWNERS file #728
Conversation
|
//cc: @apache/struts-committers |
|
Kudos, SonarCloud Quality Gate passed!
|
| @@ -0,0 +1,2 @@ | |||
| # Request PR review from any Apache Struts committer | |||
| * @apache/struts-committers | |||
There was a problem hiding this comment.
I think GitHub doesn't like the *
There was a problem hiding this comment.
I was basing on the example file - yet we do not include/exclude any other specific patterns
There was a problem hiding this comment.
Ah it might be complaining because it's a private team
There was a problem hiding this comment.
Right... not sure why this team is private as all committers are publicly known
There was a problem hiding this comment.
But where exactly are all struts-committers defined as a group on GitHub? I couldn't find any reference.
There was a problem hiding this comment.
I assume this is autogenerated group by ASF Infra base on the ASF records, yet I'm not sure which one is used for that as it doesn't include all the committers
https://people.apache.org/phonebook.html?unix=struts
There was a problem hiding this comment.
I see a list of 11 people - presumably the Struts committers who have made their Apache org membership public (private by default)?
There was a problem hiding this comment.
As far I understand you must link your GH account to the ASF account to be added to the team, yet still there is a difference.
There was a problem hiding this comment.
For reference https://issues.apache.org/jira/browse/INFRA-24905
About code owners