WW-5334 Enable usage of junit-plugin inside velocity-plugin #732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kusalk
commented
Aug 18, 2023
| @@ -65,35 +62,6 @@ public void testGetValueFromStack() throws ServletException, UnsupportedEncoding | |||
| assertEquals("FD", name); | |||
| } | |||
|
|
|||
| @Test | |||
| public void shouldPortletContextBeAvailable() throws Exception { | |||
There was a problem hiding this comment.
These tests didn't run nor pass previously
lukaszlenart
requested changes
Aug 18, 2023
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WW-5334
I extracted
StrutsPortletTestCaseinto its own module fromstruts-junit-pluginto resolve the previous cyclic dependency (junit -> portlet -> velocity -> junit) which was preventing me from usingstruts-junit-pluginto write unit tests forstruts-velocity-plugin.See commit messages for other assorted clean up.