Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drops duplicated dependency #737

Merged
merged 1 commit into from
Aug 22, 2023
Merged

Drops duplicated dependency #737

merged 1 commit into from
Aug 22, 2023

Conversation

lukaszlenart
Copy link
Member

Closes #722

@lukaszlenart lukaszlenart added Lazy Consensus dependencies Pull requests that update a dependency file labels Aug 22, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

sepe81
sepe81 approved these changes Aug 22, 2023
View reviewed changes
Copy link
Contributor

@sepe81 sepe81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, mvn dependency:tree shows just javax.servlet:javax.servlet-api:jar:3.1.0:provided

@lukaszlenart lukaszlenart merged commit c087f2e into master Aug 22, 2023
@lukaszlenart lukaszlenart deleted the fix/drops-duplicated-dependency branch August 22, 2023 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sepe81 sepe81 sepe81 approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file Lazy Consensus
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lukaszlenart @sepe81