Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split SonarCloud into separate action #755

Merged
merged 1 commit into from
Sep 26, 2023
Merged

Conversation

kusalk
Copy link
Member

@kusalk kusalk commented Sep 18, 2023

Pull requests from forked repos cannot run the Sonar scan due to restricted secret access. To avoid a situation where we miss a failing test on JDK17, I've split the Sonar scan into its own job. It is also less confusing for contributors.

I've additionally replaced the cache step with the preset cache configuration in the setup-java step.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@kusalk kusalk marked this pull request as ready for review September 18, 2023 11:04
Copy link
Member

@lukaszlenart lukaszlenart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice :) LGTM 👍

@lukaszlenart lukaszlenart merged commit 9540ba6 into master Sep 26, 2023
8 checks passed
@lukaszlenart lukaszlenart deleted the gh-actions-sonar branch September 26, 2023 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants