WW-5363 Velocity: read chained contexts before ValueStack #789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kusalk
force-pushed
the
issue/WW-5363-velocity-order
branch
from
926a846 to
86498fd
Compare
kusalk
force-pushed
the
issue/WW-5363-velocity-order
branch
from
86498fd to
aff5a55
Compare
kusalk
commented
Nov 13, 2023
| } | ||
|
|
||
| protected List<Function<String, Object>> contextGetterList() { | ||
| return Arrays.asList(super::internalGet, this::chainedContextGet, this::stackGet, this::stackContextGet); |
There was a problem hiding this comment.
Happy to revert this back to the original order if you think that's a more sensible default - at least now it is easily overridable
There was a problem hiding this comment.
I think this is fine, we will see if this will produce some backward incompatibility
kusalk
force-pushed
the
issue/WW-5363-velocity-order
branch
from
aff5a55 to
cf9e535
Compare
|
Kudos, SonarCloud Quality Gate passed! |
lukaszlenart
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WW-5363
I think it's probably a fair assumption that in most applications that the OgnlValueStack lookup will be the most expensive context lookup. Given that, it is probably better we do that last. I've refactored this class slightly to make the lookup order easily overridable.