WW-5381 Introduce extension point for MethodAccessor #825
Conversation
| @@ -87,12 +92,6 @@ protected void setContainer(Container container) throws ClassNotFoundException { | |||
| OgnlRuntime.setPropertyAccessor(cls, container.getInstance(PropertyAccessor.class, name)); | |||
| } | |||
|
|
|||
| names = container.getInstanceNames(MethodAccessor.class); | |||
There was a problem hiding this comment.
Now there is one drawback here - applications lose the ability to specify custom method accessors for different types. They will now instead need to use the extension point and do the delegation within this "global" method accessor. I'm not sure there's a way to retain this capability and make it compatible with the current extension point system.
There was a problem hiding this comment.
Hmm... so maybe just mark this functionality as @deprecated or remove - once someone starts complain we can re-think how to put back such functionality.
There was a problem hiding this comment.
Hmm actually just had another think and we should be able to retain backwards compatibility, the code will be a little ugly though - let me give it a shot
There was a problem hiding this comment.
I think we are good now :) Hopefully the code makes sense, added some JavaDoc
kusalk
force-pushed
the
WW-5381-method-accessor
branch
from
588d6fc to
c322aba
Compare
|
(SonarCloud report is comparing against wrong base branch) |
kusalk
force-pushed
the
WW-5381-method-accessor
branch
from
7de06b1 to
573dbbc
Compare
kusalk
force-pushed
the
WW-5381-compoundroot-interface-2
branch
from
4ae768e to
f3c160d
Compare
|
WW-5381
Fairly straight forward again but see my comment below