[WW-5383] Updates RegEx to excludes JARs by default #830
Conversation
lukaszlenart
requested review from
rgielen,
aleksandr-m,
yasserzamani,
sdutry,
cnenning and
kusalk
| && (alwaysMapExecute || map.isEmpty())) { | ||
| && hasDefaultMethod | ||
| && actionAnnotation == null && actionsAnnotation == null | ||
| && (alwaysMapExecute || map.isEmpty())) { |
There was a problem hiding this comment.
My personal preference is to use double indents for continuations - it avoids situations like these where the guard blends in with the following code
There was a problem hiding this comment.
I'm using standard IDEA settings, yet it would be good to introduce a common IDE independent mechanism to format code.
There was a problem hiding this comment.
IMHO Eclipse does this by default, IntelliJ not.
We could introduce .editorconfig settings. The following setting does the job:
[*.java]
continuation_indent_size = 8
There was a problem hiding this comment.
Just checked this as I was curious and doesn't seem to be the case (at least on the version I'm using)
There was a problem hiding this comment.
Oh, right! Just checked my settings and it was 4 for continuation, reverted to default one :)
| * can return also a sub-path like "!/META-INF/versions/..." | ||
| */ | ||
| private static final String EXCLUDE_ALL_JARS_PATTERN = ".*?\\.jar(!/|/)?(.*)?"; | ||
| private static final String DEFAULT_SPLIT_PATTERN = "\\s*,\\s*"; |
There was a problem hiding this comment.
looks good without the original [,] 👍
| } | ||
| urlSet = urlSet.excludePaths(System.getProperty("sun.boot.class.path", "")); | ||
| urlSet = urlSet.exclude(".*/JavaVM.framework/.*"); | ||
|
|
||
| if (includeJars == null) { | ||
| urlSet = urlSet.exclude(".*?\\.jar(!/|/)?"); | ||
| LOG.debug("\"{}\" is not defined, excluding all JAR files!", ConventionConstants.CONVENTION_ACTION_INCLUDE_JARS); | ||
| urlSet = urlSet.exclude(EXCLUDE_ALL_JARS_PATTERN); |
There was a problem hiding this comment.
I guess the extra (.*)? from EXCLUDE_ALL_JARS_PATTERN = ".*?\\.jar(!/|/)?(.*)?"; is intentional, isn't it?
There was a problem hiding this comment.
Yes, since JDK9 we can get either jar:file:/.../org/codehaus/plexus/plexus-utils/3.4.1/plexus-utils-3.4.1.jar!/META-INF/versions/10/ or just jar:file:/.../org/codehaus/plexus/plexus-utils/3.4.1/plexus-utils-3.4.1.jar!/
asfgit
force-pushed
the
feature/WW-5383-exclude-jars
branch
from
151970a to
cc78033
Compare
|
Closes WW-5383