Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

s:file shows server/file location WW-5396 #876

Merged
merged 4 commits into from
Feb 16, 2024

Conversation

gregh3269
Copy link
Contributor

After a file upload with the s:file tag it gives details of the webapp location in the value attribute.

@lukaszlenart
Copy link
Member

Wouldn't be better to simple override the setValue() in the File.java?

    @Override
    @StrutsTagAttribute(description="Ignored during file upload")
    public void setValue(String value) {
        // ignores provided value
    }

@gregh3269
Copy link
Contributor Author

OK, good idea, we can see what it does. I will amend the PR.

@gregh3269
Copy link
Contributor Author

I ran the FileTest.java and it passed.

@lukaszlenart
Copy link
Member

Please add re-generated file-attributes.html as well

@lukaszlenart lukaszlenart merged commit a84f857 into apache:master Feb 16, 2024
7 checks passed
@gregh3269 gregh3269 deleted the fix-for-WW-5396 branch February 16, 2024 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants