WW-5353 Stronger security defaults for 7.0 #919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kusalk
force-pushed
the
WW-5353-stronger-security-defaults
branch
from
5d9c039 to
9f9a0e3
Compare
kusalk
commented
Apr 20, 2024
|
|
||
| /** | ||
| * Generic test setup methods to be used with any unit testing framework. | ||
| */ | ||
| public class StrutsTestCaseHelper { | ||
|
|
||
| public static Dispatcher initDispatcher(ServletContext ctx, Map<String, String> params) { | ||
| Dispatcher du = new DispatcherWrapper(ctx, params != null ? params : emptyMap()); | ||
| var finalParams = new HashMap<>(params); | ||
| finalParams.putIfAbsent(STRUTS_ALLOWLIST_ENABLE, "false"); |
There was a problem hiding this comment.
I think it makes sense to keep the allowlist disabled for unit tests as the auto-allowlisting is only effective in production applications
kusalk
force-pushed
the
merge-master-to-70-2024-04-20
branch
from
8ad75f2 to
570f634
Compare
kusalk
force-pushed
the
WW-5353-stronger-security-defaults
branch
from
0d614a7 to
9adc618
Compare
kusalk
force-pushed
the
merge-master-to-70-2024-04-20
branch
from
570f634 to
d0204f3
Compare
kusalk
force-pushed
the
WW-5353-stronger-security-defaults
branch
2 times, most recently
from
5e80a32 to
f57b7c8
Compare
kusalk
force-pushed
the
WW-5353-stronger-security-defaults
branch
from
f57b7c8 to
5d4ad83
Compare
|
Base automatically changed from
merge-master-to-70-2024-04-20
to
release/struts-7-0-x
April 20, 2024 14:54
lukaszlenart
approved these changes
Apr 24, 2024
|
Feedback on the next milestone will be interesting, let's see how we go! |
|
I can roll a new Milestone release during the weekend |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WW-5353