[WW-5419] Fixes support for loading Tiles definitions #920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukaszlenart
requested review from
rgielen,
aleksandr-m,
yasserzamani,
sdutry,
cnenning and
kusalk
|
/cc: @gregh3269 |
asfgit
force-pushed
the
fix/WW-5419-tiles
branch
from
e8caaac to
b174f3e
Compare
kusalk
reviewed
Apr 22, 2024
| /** | ||
| * Default pattern to be used to collect Tiles definitions if user didn't configure any | ||
| */ | ||
| public static final Set<String> TILES_DEFAULT_PATTERNS = Collections.unmodifiableSet(new HashSet<>(Arrays.asList( |
There was a problem hiding this comment.
Technically you need to deprecate this since it's been released in 6.4.0. But also there's no need to create the set anew each time below. You can just keep this field as is and update the value like so:
public static final Set<String> TILES_DEFAULT_PATTERNS = TextParseUtil.commaDelimitedStringToSet("*tiles*.xml");
asfgit
force-pushed
the
fix/WW-5419-tiles
branch
from
b174f3e to
a88cb74
Compare
|
kusalk
approved these changes
Apr 22, 2024
|
Looks ok |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes WW-5419