WW-5415 Fixes accessing public constructors via expression #933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukaszlenart
commented
May 12, 2024
| @@ -147,7 +147,7 @@ public boolean isAccessible(Map context, Object target, Member member, String pr | |||
| if (target != null) { | |||
| // Special case: Target is a Class object but not Class.class | |||
| if (Class.class.equals(target.getClass()) && !Class.class.equals(target)) { | |||
| if (!isStatic(member)) { | |||
| if (!isStatic(member) && Arrays.stream(((Class<?>) target).getConstructors()).noneMatch(p -> p.getClass().equals(member.getClass()))) { | |||
There was a problem hiding this comment.
This is just a temporary solution to express where the problem is, @kusalk I count on your comment :)
There was a problem hiding this comment.
Thanks @lukaszlenart for writing the test case - I did indeed overlook the constructor case, I've pushed a commit to this PR with the appropriate fix :)
kusalk
approved these changes
May 13, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes creating instances via OGNL expressions. The breaking change was introduced in #780
Closes WW-5415