add allowed methods to handleUnknownAction #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IMHO a getter @lukaszlenart Do you see reasons not to add the getter? |
…onConfig method in ConventionUnknownHandler to reference it
|
Agreed. I added it. |
|
Please create a jira ticket, too. We usually document all changes in jira to generate change logs. |
| * | ||
| * @return a Set of method names allowed to be executed if strict method invocation is enabled | ||
| */ | ||
| public Set<String> getGlobalAllowedMethods() { return globalAllowedMethods; } |
There was a problem hiding this comment.
Can this return unmodifiable collections?
There was a problem hiding this comment.
Ok, I will do it after merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to strict-method-invocation, the convention plugin would allow for executing results (JSP) without an associated Action via the ConventionUnknownHandler.handleUnknownAction method. This continues to work with SMI disabled but when enabled the allowedMethods list in the ActionConfig does not get populated which causes a 404. There was already a member Set hard coded to the most common methods to which I added "index" used by the REST plugin.
Ideally, line 224 would use the globalAllowedMethods set from the PackageConfig instead of a hard coded list but there is currently no associated getter method and I figured it would be better to discuss adding that functionality via the PR.