chore: Renamed changed/created_on to changed/created_at

apache · Aug 28, 2020 · 3bb0dd3 · 3bb0dd3
1 parent 3e374da
commit 3bb0dd3
Show file tree

Hide file tree

Showing 72 changed files with 364 additions and 231 deletions.
diff --git a/UPDATING.md b/UPDATING.md
@@ -23,6 +23,9 @@ assists people when migrating to a new version.
 
 ## Next
 
+* [10719](https://github.com/apache/incubator-superset/pull/10719): a change which renames the changed_on and created_on columns to changed_at and created_at respectively. This change alters a number of tables including the heavily leveraged `query` table (which additionally requires dropping and recreating an index) and thus scheduled downtime is advised. This also impacts the cache key and thus as a consequence all
+previously cached results will be invalidated.
+
 * [10674](https://github.com/apache/incubator-superset/pull/10674): Breaking change: PUBLIC_ROLE_LIKE_GAMMA was removed is favour of the new PUBLIC_ROLE_LIKE so it can be set it whatever role you want.
 
 * [10590](https://github.com/apache/incubator-superset/pull/10590): Breaking change: this PR will convert iframe chart into dashboard markdown component, and remove all `iframe`, `separator`, and `markup` slices (and support) from Superset. If you have important data in those slices, please backup manually.

diff --git a/superset-frontend/spec/javascripts/dashboard/components/SliceAdder_spec.jsx b/superset-frontend/spec/javascripts/dashboard/components/SliceAdder_spec.jsx
@@ -48,8 +48,8 @@ describe('SliceAdder', () => {
   describe('SliceAdder.sortByComparator', () => {
     it('should sort by timestamp descending', () => {
       const sortedTimestamps = Object.values(props.slices)
-        .sort(SliceAdder.sortByComparator('changed_on'))
-        .map(slice => slice.changed_on);
+        .sort(SliceAdder.sortByComparator('changed_at'))
+        .map(slice => slice.changed_at);
       expect(
         sortedTimestamps.every((currentTimestamp, index) => {
           if (index === 0) {

diff --git a/superset-frontend/spec/javascripts/dashboard/fixtures/mockSliceEntities.js b/superset-frontend/spec/javascripts/dashboard/fixtures/mockSliceEntities.js
@@ -51,7 +51,7 @@ export const sliceEntitiesForChart = {
       description: null,
       description_markeddown: '',
       modified: '23 hours ago',
-      changed_on: 1529453332615,
+      changed_at: 1529453332615,
     },
   },
   isLoading: false,
@@ -84,7 +84,7 @@ export const sliceEntitiesForDashboard = {
       description: null,
       description_markeddown: '',
       modified: '23 hours ago',
-      changed_on: 1529453332615,
+      changed_at: 1529453332615,
     },
     128: {
       slice_id: 128,
@@ -97,7 +97,7 @@ export const sliceEntitiesForDashboard = {
       description: null,
       description_markeddown: '',
       modified: '23 hours ago',
-      changed_on: 1529453332628,
+      changed_at: 1529453332628,
     },
     129: {
       slice_id: 129,
@@ -110,7 +110,7 @@ export const sliceEntitiesForDashboard = {
       description: null,
       description_markeddown: '',
       modified: '23 hours ago',
-      changed_on: 1529453332637,
+      changed_at: 1529453332637,
     },
     130: {
       slice_id: 130,
@@ -123,7 +123,7 @@ export const sliceEntitiesForDashboard = {
       description: null,
       description_markeddown: '',
       modified: '23 hours ago',
-      changed_on: 1529453332645,
+      changed_at: 1529453332645,
     },
     131: {
       slice_id: 131,
@@ -136,7 +136,7 @@ export const sliceEntitiesForDashboard = {
       description: null,
       description_markeddown: '',
       modified: '23 hours ago',
-      changed_on: 1529453332654,
+      changed_at: 1529453332654,
     },
     132: {
       slice_id: 132,
@@ -149,7 +149,7 @@ export const sliceEntitiesForDashboard = {
       description: null,
       description_markeddown: '',
       modified: '23 hours ago',
-      changed_on: 1529453332663,
+      changed_at: 1529453332663,
     },
     133: {
       slice_id: 133,
@@ -162,7 +162,7 @@ export const sliceEntitiesForDashboard = {
       description: null,
       description_markeddown: '',
       modified: '23 hours ago',
-      changed_on: 1529453332673,
+      changed_at: 1529453332673,
     },
     134: {
       slice_id: 134,
@@ -175,7 +175,7 @@ export const sliceEntitiesForDashboard = {
       description: null,
       description_markeddown: '',
       modified: '23 hours ago',
-      changed_on: 1529453332680,
+      changed_at: 1529453332680,
     },
     135: {
       slice_id: 135,
@@ -188,7 +188,7 @@ export const sliceEntitiesForDashboard = {
       description: null,
       description_markeddown: '',
       modified: '23 hours ago',
-      changed_on: 1529453332688,
+      changed_at: 1529453332688,
     },
     136: {
       slice_id: 136,
@@ -201,7 +201,7 @@ export const sliceEntitiesForDashboard = {
       description: null,
       description_markeddown: '',
       modified: '23 hours ago',
-      changed_on: 1529453332700,
+      changed_at: 1529453332700,
     },
   },
   isLoading: false,

diff --git a/superset-frontend/spec/javascripts/sqllab/fixtures.ts b/superset-frontend/spec/javascripts/sqllab/fixtures.ts
@@ -149,13 +149,13 @@ export const table = {
       indexed: false,
       longType: 'DATETIME',
       type: 'DATETIME',
-      name: 'created_on',
+      name: 'created_at',
     },
     {
       indexed: false,
       longType: 'DATETIME',
       type: 'DATETIME',
-      name: 'changed_on',
+      name: 'changed_at',
     },
     {
       indexed: true,
@@ -205,7 +205,7 @@ export const queries = [
     tempTable: null,
     userId: 1,
     executedSql: null,
-    changed_on: '2016-10-19T20:56:06',
+    changed_at: '2016-10-19T20:56:06',
     rows: 42,
     endDttm: 1476910566798,
     limit_reached: false,
@@ -263,11 +263,11 @@ export const queries = [
     tempTable: null,
     userId: 1,
     executedSql:
-      'SELECT * \nFROM (SELECT created_on, changed_on, id, slice_name, ' +
+      'SELECT * \nFROM (SELECT created_at, changed_at, id, slice_name, ' +
       'druid_datasource_id, table_id, datasource_type, datasource_name, ' +
       'viz_type, params, created_by_fk, changed_by_fk, description, ' +
       'cache_timeout, perm\nFROM superset.slices) AS inner_qry \n LIMIT 1000',
-    changed_on: '2016-10-19T20:56:12',
+    changed_at: '2016-10-19T20:56:12',
     rows: 42,
     endDttm: 1476910579693,
     limit_reached: false,

diff --git a/superset-frontend/spec/javascripts/views/CRUD/chart/ChartList_spec.jsx b/superset-frontend/spec/javascripts/views/CRUD/chart/ChartList_spec.jsx
@@ -41,7 +41,7 @@ const chartsVizTypesEndpoint = 'glob:*/api/v1/chart/viz_types';
 const chartsDtasourcesEndpoint = 'glob:*/api/v1/chart/datasources';
 
 const mockCharts = [...new Array(3)].map((_, i) => ({
-  changed_on: new Date().toISOString(),
+  changed_at: new Date().toISOString(),
   creator: 'super user',
   id: i,
   slice_name: `cool chart ${i}`,
@@ -110,7 +110,7 @@ describe('ChartList', () => {
     const callsD = fetchMock.calls(/chart\/\?q/);
     expect(callsD).toHaveLength(1);
     expect(callsD[0][0]).toMatchInlineSnapshot(
-      `"http://localhost/api/v1/chart/?q=(order_column:changed_on_delta_humanized,order_direction:desc,page:0,page_size:25)"`,
+      `"http://localhost/api/v1/chart/?q=(order_column:changed_at_delta_humanized,order_direction:desc,page:0,page_size:25)"`,
     );
   });
 

diff --git a/superset-frontend/spec/javascripts/views/CRUD/dashboard/DashboardList_spec.jsx b/superset-frontend/spec/javascripts/views/CRUD/dashboard/DashboardList_spec.jsx
@@ -47,8 +47,8 @@ const mockDashboards = [...new Array(3)].map((_, i) => ({
   changed_by_url: 'changed_by_url',
   changed_by_fk: 1,
   published: true,
-  changed_on_utc: new Date().toISOString(),
-  changed_on_delta_humanized: '5 minutes ago',
+  changed_at_utc: new Date().toISOString(),
+  changed_at_delta_humanized: '5 minutes ago',
   owners: [{ first_name: 'admin', last_name: 'admin_user' }],
   thumbnail_url: '/thumbnail',
 }));
@@ -103,7 +103,7 @@ describe('DashboardList', () => {
     const callsD = fetchMock.calls(/dashboard\/\?q/);
     expect(callsD).toHaveLength(1);
     expect(callsD[0][0]).toMatchInlineSnapshot(
-      `"http://localhost/api/v1/dashboard/?q=(order_column:changed_on_delta_humanized,order_direction:desc,page:0,page_size:25)"`,
+      `"http://localhost/api/v1/dashboard/?q=(order_column:changed_at_delta_humanized,order_direction:desc,page:0,page_size:25)"`,
     );
   });
 

diff --git a/superset-frontend/spec/javascripts/views/CRUD/data/dataset/DatasetList_spec.jsx b/superset-frontend/spec/javascripts/views/CRUD/data/dataset/DatasetList_spec.jsx
@@ -43,7 +43,7 @@ const mockdatasets = [...new Array(3)].map((_, i) => ({
   kind: i === 0 ? 'virtual' : 'physical', // ensure there is 1 virtual
   changed_by_url: 'changed_by_url',
   changed_by: 'user',
-  changed_on: new Date().toISOString(),
+  changed_at: new Date().toISOString(),
   database_name: `db ${i}`,
   explore_url: `/explore/table/${i}`,
   id: i,
@@ -99,7 +99,7 @@ describe('DatasetList', () => {
     const callsD = fetchMock.calls(/dataset\/\?q/);
     expect(callsD).toHaveLength(2);
     expect(callsD[1][0]).toMatchInlineSnapshot(
-      `"http://localhost/api/v1/dataset/?q=(order_column:changed_on_delta_humanized,order_direction:desc,page:0,page_size:25)"`,
+      `"http://localhost/api/v1/dataset/?q=(order_column:changed_at_delta_humanized,order_direction:desc,page:0,page_size:25)"`,
     );
   });
 

diff --git a/superset-frontend/src/components/OmniContainer.jsx b/superset-frontend/src/components/OmniContainer.jsx
@@ -33,7 +33,7 @@ const getDashboards = query =>
   // todo: Build a dedicated endpoint for dashboard searching
   // i.e. superset/v1/api/dashboards?q=${query}
   SupersetClient.get({
-    endpoint: `/dashboardasync/api/read?_oc_DashboardModelViewAsync=changed_on&_od_DashboardModelViewAsync=desc&_flt_2_dashboard_title=${query}`,
+    endpoint: `/dashboardasync/api/read?_oc_DashboardModelViewAsync=changed_at&_od_DashboardModelViewAsync=desc&_flt_2_dashboard_title=${query}`,
   })
     .then(({ json }) =>
       json.result.map(item => ({

diff --git a/superset-frontend/src/dashboard/actions/sliceEntities.js b/superset-frontend/src/dashboard/actions/sliceEntities.js
@@ -72,12 +72,12 @@ export function fetchAllSlices(userId) {
                 form_data,
                 datasource_name: slice.datasource_name_text,
                 datasource_link: slice.datasource_link,
-                changed_on: new Date(slice.changed_on).getTime(),
+                changed_at: new Date(slice.changed_at).getTime(),
                 description: slice.description,
                 description_markdown: slice.description_markeddown,
                 viz_type: slice.viz_type,
                 modified: slice.modified,
-                changed_on_humanized: slice.changed_on_humanized,
+                changed_at_humanized: slice.changed_at_humanized,
               };
             }
           });

diff --git a/superset-frontend/src/dashboard/components/SliceAdder.jsx b/superset-frontend/src/dashboard/components/SliceAdder.jsx
@@ -56,7 +56,7 @@ const KEYS_TO_SORT = [
   { key: 'slice_name', label: 'Name' },
   { key: 'viz_type', label: 'Vis type' },
   { key: 'datasource_name', label: 'Datasource' },
-  { key: 'changed_on', label: 'Recent' },
+  { key: 'changed_at', label: 'Recent' },
 ];
 
 const MARGIN_BOTTOM = 16;
@@ -66,7 +66,7 @@ const DEFAULT_CELL_HEIGHT = 112;
 
 class SliceAdder extends React.Component {
   static sortByComparator(attr) {
-    const desc = attr === 'changed_on' ? -1 : 1;
+    const desc = attr === 'changed_at' ? -1 : 1;
 
     return (a, b) => {
       if (a[attr] < b[attr]) {
@@ -83,7 +83,7 @@ class SliceAdder extends React.Component {
     this.state = {
       filteredSlices: [],
       searchTerm: '',
-      sortBy: KEYS_TO_SORT.findIndex(item => item.key === 'changed_on'),
+      sortBy: KEYS_TO_SORT.findIndex(item => item.key === 'changed_at'),
       selectedSliceIdsSet: new Set(props.selectedSliceIds),
     };
     this.rowRenderer = this.rowRenderer.bind(this);
@@ -188,7 +188,7 @@ class SliceAdder extends React.Component {
             innerRef={dragSourceRef}
             style={style}
             sliceName={cellData.slice_name}
-            lastModified={cellData.changed_on_humanized}
+            lastModified={cellData.changed_at_humanized}
             visType={cellData.viz_type}
             datasourceUrl={cellData.datasource_url}
             datasourceName={cellData.datasource_name}

diff --git a/superset-frontend/src/dashboard/components/dnd/AddSliceDragPreview.jsx b/superset-frontend/src/dashboard/components/dnd/AddSliceDragPreview.jsx
@@ -72,7 +72,7 @@ function AddSliceDragPreview({ dragItem, slices, isDragging, currentOffset }) {
         transform: `translate(${currentOffset.x}px, ${currentOffset.y}px)`,
       }}
       sliceName={slice.slice_name}
-      lastModified={slice.changed_on_humanized}
+      lastModified={slice.changed_at_humanized}
       visType={slice.viz_type}
       datasourceUrl={slice.datasource_url}
       datasourceName={slice.datasource_name}

diff --git a/superset-frontend/src/dashboard/reducers/getInitialState.js b/superset-frontend/src/dashboard/reducers/getInitialState.js
@@ -134,7 +134,7 @@ export default function (bootstrapData) {
       description_markeddown: slice.description_markeddown,
       owners: slice.owners,
       modified: slice.modified,
-      changed_on: new Date(slice.changed_on).getTime(),
+      changed_at: new Date(slice.changed_at).getTime(),
     };
 
     sliceIds.add(key);

diff --git a/superset-frontend/src/dashboard/util/propShapes.jsx b/superset-frontend/src/dashboard/util/propShapes.jsx
@@ -63,7 +63,7 @@ export const slicePropShape = PropTypes.shape({
   datasource: PropTypes.string,
   datasource_name: PropTypes.string,
   datasource_link: PropTypes.string,
-  changed_on: PropTypes.number.isRequired,
+  changed_at: PropTypes.number.isRequired,
   modified: PropTypes.string.isRequired,
   viz_type: PropTypes.string.isRequired,
   description: PropTypes.string,

diff --git a/superset-frontend/src/types/Chart.ts b/superset-frontend/src/types/Chart.ts
@@ -29,11 +29,11 @@ export default interface Chart {
   viz_type: string;
   slice_name: string;
   creator: string;
-  changed_on: string;
+  changed_at: string;
   description: string | null;
   cache_timeout: number | null;
   thumbnail_url?: string;
-  changed_on_delta_humanized?: string;
+  changed_at_delta_humanized?: string;
   owners?: Owner[];
   datasource_name_text?: string;
 }
diff --git a/superset-frontend/src/views/CRUD/chart/ChartList.tsx b/superset-frontend/src/views/CRUD/chart/ChartList.tsx
@@ -113,7 +113,7 @@ function ChartList(props: ChartListProps) {
 
   const canEdit = hasPerm('can_edit');
   const canDelete = hasPerm('can_delete');
-  const initialSort = [{ id: 'changed_on_delta_humanized', desc: true }];
+  const initialSort = [{ id: 'changed_at_delta_humanized', desc: true }];
 
   function openChartEditModal(chart: Chart) {
     setSliceCurrentlyEditing({
@@ -238,11 +238,11 @@ function ChartList(props: ChartListProps) {
       {
         Cell: ({
           row: {
-            original: { changed_on_delta_humanized: changedOn },
+            original: { changed_at_delta_humanized: changedOn },
           },
         }: any) => <span className="no-wrap">{changedOn}</span>,
         Header: t('Last Modified'),
-        accessor: 'changed_on_delta_humanized',
+        accessor: 'changed_at_delta_humanized',
       },
       {
         accessor: 'description',
@@ -379,13 +379,13 @@ function ChartList(props: ChartListProps) {
     },
     {
       desc: true,
-      id: 'changed_on_delta_humanized',
+      id: 'changed_at_delta_humanized',
       label: 'Recently Modified',
       value: 'recently_modified',
     },
     {
       desc: false,
-      id: 'changed_on_delta_humanized',
+      id: 'changed_at_delta_humanized',
       label: 'Least Recently Modified',
       value: 'least_recently_modified',
     },
@@ -438,7 +438,7 @@ function ChartList(props: ChartListProps) {
         url={bulkSelectEnabled ? undefined : chart.url}
         imgURL={chart.thumbnail_url ?? ''}
         imgFallbackURL={'/static/assets/images/chart-card-fallback.png'}
-        description={t('Last modified %s', chart.changed_on_delta_humanized)}
+        description={t('Last modified %s', chart.changed_at_delta_humanized)}
         coverLeft={(chart.owners || []).slice(0, 5).map(owner => (
           <AvatarIcon
             key={owner.id}