curious

apache · Oct 21, 2022 · 67c3f20 · 67c3f20
1 parent 04bec5c
commit 67c3f20
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/superset/sqllab/command.py b/superset/sqllab/command.py
@@ -116,11 +116,11 @@ def run(  # pylint: disable=too-many-statements,useless-suppression
             }
         except (SupersetErrorsException, SupersetException) as ex:
             if ex.status != 422:
-                query_id = query.id if query else None
+                query_id = query.id if query else -1
                 logger.exception("Query %d: %s", query_id, type(ex))
             raise ex
         except Exception as ex:
-            query_id = query.id if query else None
+            query_id = query.id if query else -1
             logger.exception("Query %d: %s", query_id, type(ex))
             raise SqlLabException(self._execution_context, exception=ex) from ex
 

diff --git a/tests/integration_tests/celery_tests.py b/tests/integration_tests/celery_tests.py
@@ -148,6 +148,7 @@ def test_run_sync_query_dont_exist(test_client, ctas_method):
     engine_name = examples_db.db_engine_spec.engine_name
     sql_dont_exist = "SELECT name FROM table_dont_exist"
     result = run_sql(test_client, sql_dont_exist, cta=True, ctas_method=ctas_method)
+    print(result)
     if backend() == "sqlite" and ctas_method == CtasMethod.VIEW:
         assert QueryStatus.SUCCESS == result["status"], result
     elif backend() == "presto":