Skip to content

Commit

Permalink
add back validation
Browse files Browse the repository at this point in the history
  • Loading branch information
hughhhh committed Jun 17, 2021
1 parent 42ac287 commit 88ca153
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions superset/databases/schemas.py
Original file line number Diff line number Diff line change
Expand Up @@ -354,9 +354,8 @@ def validate_parameters( # pylint: disable=no-self-use
Validate the DB engine spec specific parameters schema.
"""
# TODO (aafghahi): Move this onCreate instead of validation
# engine_spec = get_engine_spec(data.get("engine") or data.get("backend"))
# engine_spec.parameters_schema.load(data["parameters"]) # type: ignore
return None
engine_spec = get_engine_spec(data.get("engine") or data.get("backend"))
engine_spec.parameters_schema.load(data["parameters"]) # type: ignore


class DatabasePostSchema(Schema, DatabaseParametersSchemaMixin):
Expand Down

0 comments on commit 88ca153

Please sign in to comment.