chore: filter undefined operators (#20157)

apache · May 23, 2022 · d7e3ac3 · d7e3ac3
1 parent 56e9695
commit d7e3ac3
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 11 deletions.
diff --git a/superset-frontend/packages/superset-ui-core/src/query/buildQueryContext.ts b/superset-frontend/packages/superset-ui-core/src/query/buildQueryContext.ts
@@ -61,18 +61,25 @@ export default function buildQueryContext(
   } = typeof options === 'function'
     ? { buildQuery: options, queryFields: {} }
     : options || {};
+  const queries = buildQuery(buildQueryObject(formData, queryFields), {
+    extras: {},
+    ownState,
+    hooks: {
+      setDataMask: () => {},
+      setCachedChanges: () => {},
+      ...hooks,
+    },
+  });
+  queries.forEach(query => {
+    if (Array.isArray(query.post_processing)) {
+      // eslint-disable-next-line no-param-reassign
+      query.post_processing = query.post_processing.filter(Boolean);
+    }
+  });
   return {
     datasource: new DatasourceKey(formData.datasource).toObject(),
     force: formData.force || false,
-    queries: buildQuery(buildQueryObject(formData, queryFields), {
-      extras: {},
-      ownState,
-      hooks: {
-        setDataMask: () => {},
-        setCachedChanges: () => {},
-        ...hooks,
-      },
-    }),
+    queries,
     form_data: formData,
     result_format: formData.result_format || 'json',
     result_type: formData.result_type || 'full',

diff --git a/superset-frontend/plugins/plugin-chart-echarts/src/MixedTimeseries/buildQuery.ts b/superset-frontend/plugins/plugin-chart-echarts/src/MixedTimeseries/buildQuery.ts
@@ -86,7 +86,7 @@ export default function buildQuery(formData: QueryFormData) {
             is_timeseries,
           }),
           flattenOperator(fd, queryObject),
-        ].filter(Boolean),
+        ],
       } as QueryObject;
       return [normalizeOrderBy(tmpQueryObject)];
     }),

diff --git a/superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/buildQuery.ts b/superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/buildQuery.ts
@@ -100,7 +100,7 @@ export default function buildQuery(formData: QueryFormData) {
           flattenOperator(formData, baseQueryObject),
           // todo: move prophet before flatten
           prophetOperator(formData, baseQueryObject),
-        ].filter(Boolean),
+        ],
       },
     ];
   });