[bugfix] fails on None view_menu (#3155)

* [bugfix] fails on None view_menu * Update coveralls token
apache · Jul 19, 2017 · d7e4191 · d7e4191
1 parent 27fab0d
commit d7e4191
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/.coveralls.yml b/.coveralls.yml
@@ -1 +1 @@
-repo_token: eESbYiv4An6KEvjpmguDs4L7YkubXbqn1
+repo_token: 4P9MpvLrZfJKzHdGZsdV3MzO43OZJgYFn 
diff --git a/superset/security.py b/superset/security.py
@@ -164,7 +164,8 @@ def create_missing_perms():
         "Fetching a set of all perms to lookup which ones are missing")
     all_pvs = set()
     for pv in sm.get_session.query(sm.permissionview_model).all():
-        all_pvs.add((pv.permission.name, pv.view_menu.name))
+        if pv.permission and pv.view_menu:
+            all_pvs.add((pv.permission.name, pv.view_menu.name))
 
     def merge_pv(view_menu, perm):
         """Create permission view menu only if it doesn't exist"""