Remove try/catch

apache · Nov 29, 2022 · d99ad27 · d99ad27
1 parent e99fce2
commit d99ad27
Showing 1 changed file with 3 additions and 5 deletions.
diff --git a/superset/migrations/versions/2022-11-28_17-51_4ce1d9b25135_remove_filter_bar_orientation.py b/superset/migrations/versions/2022-11-28_17-51_4ce1d9b25135_remove_filter_bar_orientation.py
@@ -57,11 +57,9 @@ def downgrade():
         .all()
     )
     for dashboard in dashboards:
-        try:
-            json_meta = json.loads(dashboard.json_metadata)
-            json_meta.pop("filter_bar_orientation", None)
+        json_meta = json.loads(dashboard.json_metadata)
+        filter_bar_orientation = json_meta.pop("filter_bar_orientation", None)
+        if filter_bar_orientation:
             dashboard.json_metadata = json.dumps(json_meta)
-        except:
-            pass
     session.commit()
     session.close()