Skip to content

Commit

Permalink
[hotfix] passing payload to Slice.done everywhere
Browse files Browse the repository at this point in the history
  • Loading branch information
mistercrunch committed Jun 14, 2016
1 parent bacbd90 commit e29d71d
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion caravel/assets/visualizations/heatmap.js
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,7 @@ function heatmapVis(slice) {
imageObj.src = canvas.node().toDataURL();
}

slice.done();
slice.done(payload);

});
}
Expand Down
2 changes: 1 addition & 1 deletion caravel/assets/visualizations/horizon.js
Original file line number Diff line number Diff line change
Expand Up @@ -225,7 +225,7 @@ function horizonViz(slice) {
.call(this, d.values, i);
});

slice.done();
slice.done(payload);
});
}
return {
Expand Down
2 changes: 1 addition & 1 deletion caravel/assets/visualizations/iframe.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ function iframeWidget(slice) {
var iframe = slice.container.find('iframe');
iframe.css('height', slice.height());
iframe.attr('src', url);
slice.done();
slice.done(payload);
})
.fail(function (xhr) {
slice.error(xhr.responseText);
Expand Down
2 changes: 1 addition & 1 deletion caravel/assets/visualizations/markup.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ function markupWidget(slice) {

$.getJSON(slice.jsonEndpoint(), function (payload) {
slice.container.html(payload.data.html);
slice.done();
slice.done(payload);
})
.fail(function (xhr) {
slice.error(xhr.responseText);
Expand Down
2 changes: 1 addition & 1 deletion caravel/assets/visualizations/parallel_coordinates.js
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ function parallelCoordVis(slice) {
});
});
}
slice.done();
slice.done(payload);
})
.fail(function (xhr) {
slice.error(xhr.responseText);
Expand Down

0 comments on commit e29d71d

Please sign in to comment.