bugfix

defining defaults in thumbnails.py caused thumbnail caches invalidated.
they moved to init.

superset/tasks/thumbnails.py

@@ -44,7 +44,7 @@ def cache_chart_thumbnail(
             logger.warning("No cache set, refusing to compute")
             return None
         logger.info("Caching chart: %s", url)
-        screenshot = ChartScreenshot(url, digest, (800, 600), (800, 600))
+        screenshot = ChartScreenshot(url, digest)
         with session_scope(nullpool=True) as session:
             user = security_manager.get_user_by_username(
                 current_app.config["THUMBNAIL_SELENIUM_USER"], session=session
@@ -68,7 +68,7 @@ def cache_dashboard_thumbnail(
             logging.warning("No cache set, refusing to compute")
             return
         logger.info("Caching dashboard: %s", url)
-        screenshot = DashboardScreenshot(url, digest, (1600, 1200), (800, 600))
+        screenshot = DashboardScreenshot(url, digest)
         with session_scope(nullpool=True) as session:
             user = security_manager.get_user_by_username(
                 current_app.config["THUMBNAIL_SELENIUM_USER"], session=session

superset/utils/screenshots.py

@@ -204,9 +204,7 @@ def __init__(
         thumb_size: Optional[WindowSize] = None,
     ):
         super().__init__(url, digest)
-        self.window_size = (
-            window_size or current_app.config["WEBDRIVER_WINDOW"]["slice"]
-        )
+        self.window_size = window_size or (800, 600)
         self.thumb_size = thumb_size or (800, 600)
 
 
@@ -222,7 +220,5 @@ def __init__(
         thumb_size: Optional[WindowSize] = None,
     ):
         super().__init__(url, digest)
-        self.window_size = (
-            window_size or current_app.config["WEBDRIVER_WINDOW"]["dashboard"]
-        )
+        self.window_size = window_size or (1600, 1200)
         self.thumb_size = thumb_size or (800, 600)